nautilus_architect_ax/

execution.rs

// -------------------------------------------------------------------------------------------------
//  Copyright (C) 2015-2026 Nautech Systems Pty Ltd. All rights reserved.
//  https://nautechsystems.io
//
//  Licensed under the GNU Lesser General Public License Version 3.0 (the "License");
//  You may not use this file except in compliance with the License.
//  You may obtain a copy of the License at https://www.gnu.org/licenses/lgpl-3.0.en.html
//
//  Unless required by applicable law or agreed to in writing, software
//  distributed under the License is distributed on an "AS IS" BASIS,
//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//  See the License for the specific language governing permissions and
//  limitations under the License.
// -------------------------------------------------------------------------------------------------

//! Live execution client implementation for the AX Exchange adapter.

use std::{
    future::Future,
    time::{Duration, Instant},
};

use anyhow::Context;
use async_trait::async_trait;
use futures_util::{StreamExt, pin_mut};
use nautilus_common::{
    clients::ExecutionClient,
    live::runner::get_exec_event_sender,
    messages::execution::{
        BatchCancelOrders, CancelAllOrders, CancelOrder, GenerateFillReports,
        GenerateOrderStatusReport, GenerateOrderStatusReports, GeneratePositionStatusReports,
        ModifyOrder, QueryAccount, QueryOrder, SubmitOrder, SubmitOrderList,
    },
};
use nautilus_core::{
    AtomicMap, DurationNanos, Params, UUID4, UnixNanos,
    string::secret::SecretString,
    time::{AtomicTime, get_atomic_clock_realtime},
};
use nautilus_live::{
    ExecutionClientCore, ExecutionEventEmitter, SocketControl,
    execution::{failure::CommandFailure, reports::retain_order_status_reports},
    task::{TaskGroup, TaskGroupGuard},
};
use nautilus_model::{
    accounts::AccountAny,
    enums::{AccountType, LiquiditySide, OmsType, OrderSide, OrderStatus, OrderType, TimeInForce},
    events::{
        OrderAccepted, OrderCancelRejected, OrderCanceled, OrderEventAny, OrderExpired,
        OrderFilled, OrderInitialized, OrderRejected, OrderUpdated,
    },
    identifiers::{
        AccountId, ClientId, ClientOrderId, InstrumentId, StrategyId, TradeId, Venue, VenueOrderId,
    },
    instruments::{Instrument, InstrumentAny},
    orders::{Order, OrderAny},
    reports::{ExecutionMassStatus, FillReport, OrderStatusReport, PositionStatusReport},
    types::{AccountBalance, MarginBalance, Money, Price, Quantity},
};
use ustr::Ustr;

use crate::{
    common::{
        auth::run_auth_token_refresh,
        consts::{
            AX_ACCOUNT_REGISTRATION_TIMEOUT_SECS, AX_AUTH_TOKEN_TTL_SECS, AX_POST_ONLY_REJECT,
            AX_VENUE,
        },
        credential::Credential,
        enums::{AxOrderSide, AxTimeInForce},
        parse::{
            ax_timestamp_stn_to_unix_nanos, cid_to_client_order_id, client_order_id_to_cid,
            quantity_to_contracts,
        },
    },
    config::AxExecutionClientConfig,
    http::{
        client::AxHttpClient,
        error::AxHttpError,
        models::{AxOrderRejectReason, PreviewAggressiveLimitOrderRequest, ReplaceOrderRequest},
    },
    websocket::{
        AxOrdersWsMessage, AxWsOrderEvent,
        messages::{AxWsOrder, AxWsTradeExecution, OrderMetadata},
        orders::{AxOrdersWebSocketClient, AxOrdersWsClientError, OrdersCaches},
    },
};

/// Live execution client for the AX Exchange.
#[derive(Debug)]
pub struct AxExecutionClient {
    core: ExecutionClientCore,
    clock: &'static AtomicTime,
    config: AxExecutionClientConfig,
    emitter: ExecutionEventEmitter,
    http_client: AxHttpClient,
    ws_orders: AxOrdersWebSocketClient,
    session_tasks: TaskGroup,
    pending_tasks: TaskGroup,
    shutdown_errors: Vec<String>,
}

impl AxExecutionClient {
    /// Creates a new [`AxExecutionClient`].
    ///
    /// # Errors
    ///
    /// Returns an error if the client fails to initialize.
    pub fn new(core: ExecutionClientCore, config: AxExecutionClientConfig) -> anyhow::Result<Self> {
        let http_client = AxHttpClient::with_credentials(
            config
                .api_key
                .clone()
                .map(|value| value.into_inner())
                .unwrap_or_default(),
            config
                .api_secret
                .clone()
                .map(|value| value.into_inner())
                .unwrap_or_default(),
            Some(config.http_base_url()),
            Some(config.orders_base_url()),
            config.http_timeout_secs,
            config.max_retries,
            config.retry_delay_initial_ms,
            config.retry_delay_max_ms,
            config
                .proxy_url
                .as_ref()
                .map(|url| url.expose_secret().to_owned()),
        )?;

        let clock = get_atomic_clock_realtime();
        let trader_id = core.trader_id;
        let account_id = core.account_id;
        let emitter =
            ExecutionEventEmitter::new(clock, trader_id, account_id, AccountType::Margin, None);
        let mut ws_url = config.ws_private_url();
        if config.cancel_on_disconnect {
            let separator = if ws_url.contains('?') { "&" } else { "?" };
            ws_url.push_str(&format!("{separator}cancel_on_disconnect=true"));
        }
        let ws_orders = AxOrdersWebSocketClient::new(
            ws_url,
            account_id,
            trader_id,
            config.heartbeat_interval_secs,
            config.transport_backend,
            config
                .proxy_url
                .as_ref()
                .map(|url| url.expose_secret().to_owned()),
        )
        .with_socket_control(SocketControl::new(
            core.client_id,
            Some(*AX_VENUE),
            "architect-ax-user-streams",
        ));

        let session_tasks = TaskGroup::new();
        let pending_tasks = TaskGroup::new();

        Ok(Self {
            core,
            clock,
            config,
            emitter,
            http_client,
            ws_orders,
            session_tasks,
            pending_tasks,
            shutdown_errors: Vec::new(),
        })
    }

    async fn authenticate(&self, credential: &Credential) -> anyhow::Result<SecretString> {
        self.http_client
            .authenticate(
                credential.api_key(),
                credential.api_secret(),
                AX_AUTH_TOKEN_TTL_SECS,
            )
            .await
            .map_err(|e| anyhow::anyhow!("Authentication failed: {e}"))
    }

    fn update_account_state(&self) {
        let http_client = self.http_client.clone();
        let account_id = self.core.account_id;
        let emitter = self.emitter.clone();
        let clock = self.clock;

        self.spawn_task("query_account", async move {
            let account_state = http_client
                .request_account_state(account_id)
                .await
                .context("failed to request AX account state")?;
            let ts_event = clock.get_time_ns();
            emitter.emit_account_state(
                account_state.balances.clone(),
                account_state.margins.clone(),
                account_state.is_reported,
                ts_event,
                account_state.info,
            );
            Ok(())
        });
    }

    fn submit_order_internal(&self, cmd: &SubmitOrder) -> anyhow::Result<()> {
        let (
            order_for_task,
            client_order_id,
            strategy_id,
            instrument_id,
            order_side,
            order_type,
            quantity,
            time_in_force,
            is_post_only,
            limit_price,
        ) = {
            let cache = self.core.cache();
            let order = cache.try_order(&cmd.client_order_id)?;
            (
                order.clone(),
                order.client_order_id(),
                order.strategy_id(),
                order.instrument_id(),
                order.order_side(),
                order.order_type(),
                order.quantity(),
                order.time_in_force(),
                order.is_post_only(),
                order.price(),
            )
        };

        let ws_orders = self.ws_orders.clone();
        let trader_id = self.core.trader_id;
        let emitter = self.emitter.clone();
        let clock = self.clock;

        let http_client = self.http_client.clone();

        self.spawn_task("submit_order", async move {
            // AX emulates market orders with preview-priced IOC limits, so book moves
            // between preview and submission can produce partial fills.
            let (price, submit_time_in_force, submit_post_only) = if order_type
                == OrderType::Market
            {
                let preview_result: anyhow::Result<Price> = async {
                    let symbol = instrument_id.symbol.inner();
                    let ax_side = AxOrderSide::from(order_side);
                    let qty_contracts = quantity_to_contracts(quantity)?;

                    let instrument = http_client.get_instrument(&symbol).ok_or_else(|| {
                        anyhow::anyhow!("Instrument {instrument_id} not found in cache")
                    })?;

                    let request =
                        PreviewAggressiveLimitOrderRequest::new(symbol, qty_contracts, ax_side);
                    let response = http_client
                        .inner
                        .preview_aggressive_limit_order(&request)
                        .await
                        .map_err(|e| {
                            anyhow::anyhow!("Failed to preview aggressive limit order: {e}")
                        })?;

                    if response.remaining_quantity > 0 {
                        log::warn!(
                            "Market order book depth insufficient: \
                             filled_qty={} remaining_qty={} for {instrument_id}",
                            response.filled_quantity,
                            response.remaining_quantity,
                        );
                    }

                    let limit_price_decimal = response.limit_price.ok_or_else(|| {
                        anyhow::anyhow!(
                            "No liquidity available for market order on {instrument_id}"
                        )
                    })?;

                    let price =
                        Price::from_decimal_dp(limit_price_decimal, instrument.price_precision())
                            .with_context(|| {
                                format!(
                                    "Failed to convert AX take-through price {limit_price_decimal} for {instrument_id}"
                                )
                            })?;
                    log::debug!("Market order take-through price: {price} for {instrument_id}",);
                    Ok(price)
                }
                .await;

                let price = match preview_result {
                    Ok(price) => price,
                    Err(e) => {
                        let reason = e.to_string();
                        log::warn!(
                            "AX market order preview failed for {client_order_id}: {reason}"
                        );
                        emitter.emit_order_rejected(
                            &order_for_task,
                            &reason,
                            clock.get_time_ns(),
                            false,
                        );
                        return Ok(());
                    }
                };

                (price, TimeInForce::Ioc, false)
            } else {
                (
                    limit_price.context("AX limit order is missing a price")?,
                    time_in_force,
                    is_post_only,
                )
            };

            let result = ws_orders
                .submit_order(
                    trader_id,
                    strategy_id,
                    instrument_id,
                    client_order_id,
                    order_side,
                    quantity,
                    submit_time_in_force,
                    price,
                    submit_post_only,
                )
                .await;

            if let Err(e) = result {
                match classify_ax_ws_failure(&e) {
                    // AX classifies no send failure as a venue rejection (see
                    // `classify_ax_ws_failure`); both terminal-valid classes reject the same way.
                    CommandFailure::NotSent(reason) | CommandFailure::VenueRejected(reason) => {
                        log::warn!("AX submit failed for {client_order_id}: {reason}");
                        emitter.emit_order_rejected(
                            &order_for_task,
                            &reason,
                            clock.get_time_ns(),
                            false,
                        );
                    }
                    CommandFailure::Ambiguous(reason) => {
                        log::warn!(
                            "Ambiguous AX submit failure for {client_order_id}, awaiting reconciliation: {reason}"
                        );
                    }
                }
            }

            Ok(())
        });

        Ok(())
    }

    fn cancel_order_internal(&self, cmd: &CancelOrder) {
        let ws_orders = self.ws_orders.clone();
        let client_order_id = cmd.client_order_id;
        let venue_order_id = cmd.venue_order_id;

        // `OrderCancelRejected` comes only from the WS CancelRejected event;
        // local send failures leave the outcome to reconciliation.
        self.spawn_task("cancel_order", async move {
            if let Err(e) = ws_orders.cancel_order(client_order_id, venue_order_id).await {
                match classify_ax_ws_failure(&e) {
                    CommandFailure::NotSent(reason) | CommandFailure::VenueRejected(reason) => {
                        log::warn!("Cancel command failed for {client_order_id}: {reason}");
                    }
                    CommandFailure::Ambiguous(reason) => {
                        log::warn!(
                            "Ambiguous AX cancel failure for {client_order_id}, awaiting reconciliation: {reason}"
                        );
                    }
                }
            }

            Ok(())
        });
    }

    fn spawn_task<F>(&self, description: &'static str, fut: F)
    where
        F: Future<Output = anyhow::Result<()>> + Send + 'static,
    {
        let future = async move {
            if let Err(e) = fut.await {
                log::warn!("{description} failed: {e}");
            }
        };

        if let Err(e) = self.pending_tasks.spawn(future) {
            log::warn!("Skipping AX {description} after shutdown began: {e}");
        }
    }

    fn abort_pending_tasks(&self) {
        self.pending_tasks.begin_shutdown();
    }

    fn abort_session_tasks(&self) {
        self.session_tasks.begin_shutdown();
        self.ws_orders.begin_shutdown();
    }

    async fn await_pending_tasks(&self) -> anyhow::Result<()> {
        self.pending_tasks.begin_shutdown();
        self.pending_tasks
            .finish_shutdown(Duration::from_secs(1), Duration::from_secs(2))
            .await
            .map_err(|e| anyhow::anyhow!("Failed to terminate AX execution tasks: {e}"))?;
        Ok(())
    }

    async fn await_session_tasks(&self) -> anyhow::Result<()> {
        self.session_tasks.begin_shutdown();
        self.session_tasks
            .finish_shutdown(Duration::from_secs(1), Duration::from_secs(2))
            .await
            .map_err(|e| anyhow::anyhow!("Failed to terminate AX execution session tasks: {e}"))?;
        Ok(())
    }

    async fn teardown_partial_connect(&mut self) -> anyhow::Result<()> {
        self.abort_session_tasks();
        self.abort_pending_tasks();
        self.http_client.cancel_all_requests();

        if let Err(e) = self.ws_orders.close().await {
            self.shutdown_errors
                .push(format!("AX orders WebSocket shutdown failed: {e}"));
        }

        let (session_result, pending_result) =
            tokio::join!(self.await_session_tasks(), self.await_pending_tasks());
        self.core.set_disconnected();

        if let Err(e) = session_result {
            self.shutdown_errors.push(e.to_string());
        }

        if let Err(e) = pending_result {
            self.shutdown_errors.push(e.to_string());
        }

        if !self.shutdown_errors.is_empty() {
            anyhow::bail!(std::mem::take(&mut self.shutdown_errors).join("; "));
        }
        Ok(())
    }

    /// Polls the cache until the account is registered or timeout is reached.
    async fn await_account_registered(&self, timeout_secs: f64) -> anyhow::Result<()> {
        let account_id = self.core.account_id;

        if self.core.cache().account(&account_id).is_some() {
            log::info!("Account {account_id} registered");
            return Ok(());
        }

        let start = Instant::now();
        let timeout = Duration::from_secs_f64(timeout_secs);
        let interval = Duration::from_millis(10);

        loop {
            tokio::time::sleep(interval).await;

            if self.core.cache().account(&account_id).is_some() {
                log::info!("Account {account_id} registered");
                return Ok(());
            }

            if start.elapsed() >= timeout {
                anyhow::bail!(
                    "Timeout waiting for account {account_id} to be registered after {timeout_secs}s"
                );
            }
        }
    }
}

#[async_trait(?Send)]
impl ExecutionClient for AxExecutionClient {
    fn is_connected(&self) -> bool {
        self.core.is_connected()
    }

    fn client_id(&self) -> ClientId {
        self.core.client_id
    }

    fn account_id(&self) -> AccountId {
        self.core.account_id
    }

    fn venue(&self) -> Venue {
        *AX_VENUE
    }

    fn oms_type(&self) -> OmsType {
        self.core.oms_type
    }

    fn get_account(&self) -> Option<AccountAny> {
        self.core.cache().account_owned(&self.core.account_id)
    }

    async fn connect(&mut self) -> anyhow::Result<()> {
        if self.core.is_connected() && self.pending_tasks.is_open() && self.session_tasks.is_open()
        {
            return Ok(());
        }

        if !self.pending_tasks.is_open() || !self.session_tasks.is_open() {
            self.teardown_partial_connect().await?;
            self.pending_tasks.start_generation().map_err(|e| {
                anyhow::anyhow!("Failed to start AX execution task generation: {e}")
            })?;
            self.session_tasks.start_generation().map_err(|e| {
                anyhow::anyhow!("Failed to start AX execution session generation: {e}")
            })?;
        }
        let http_client = self.http_client.clone();
        let ws_orders = self.ws_orders.clone();
        let setup_guard =
            TaskGroupGuard::new(&[&self.session_tasks, &self.pending_tasks], move || {
                http_client.cancel_all_requests();
                ws_orders.begin_shutdown();
            });

        // Reset so requests work after a previous disconnect
        self.http_client.reset_cancellation_token();

        let credential = Credential::resolve(
            self.config.api_key.clone().map(|value| value.into_inner()),
            self.config
                .api_secret
                .clone()
                .map(|value| value.into_inner()),
        )
        .context("API credentials not configured")?;
        let token = self.authenticate(&credential).await?;

        // Instruments load after authenticating because their fee rates come from the
        // authenticated `/whoami`. A zero-fee fallback would outlive the failure that caused it,
        // since `set_instruments_initialized` stops a reconnect from retrying the load.
        if !self.core.instruments_initialized() {
            self.http_client
                .request_account_fees()
                .await
                .context("failed to resolve AX account fee rates")?;

            let instruments = self
                .http_client
                .request_instruments(None, None)
                .await
                .context("failed to request AX instruments")?;

            if instruments.is_empty() {
                log::warn!("No instruments returned from AX");
            } else {
                log::debug!("Loaded {} instruments", instruments.len());
                self.http_client.cache_instruments(&instruments);
                self.ws_orders.cache_instruments(&instruments);
            }
            self.core.set_instruments_initialized();
        }

        self.ws_orders.connect(token.expose_secret()).await?;
        log::debug!("Connected to orders WebSocket");

        let stream = self.ws_orders.stream();
        let emitter = self.emitter.clone();
        let caches = self.ws_orders.caches().clone();
        let account_id = self.core.account_id;
        let instruments_cache = self.ws_orders.instruments_cache();
        let clock = self.clock;

        if let Err(e) = self.session_tasks.spawn(async move {
            pin_mut!(stream);
            while let Some(message) = stream.next().await {
                dispatch_ws_message(
                    message,
                    &emitter,
                    &caches,
                    account_id,
                    &instruments_cache,
                    clock,
                );
            }
        }) {
            if let Err(teardown_error) = self.teardown_partial_connect().await {
                return Err(anyhow::Error::new(e).context(format!(
                    "AX execution startup teardown failed: {teardown_error}"
                )));
            }
            return Err(e.into());
        }

        let session_result = async {
            let account_state = self
                .http_client
                .request_account_state(self.core.account_id)
                .await
                .context("failed to request AX account state")?;

            if !account_state.balances.is_empty() {
                log::debug!(
                    "Received account state with {} balance(s)",
                    account_state.balances.len()
                );
            }
            self.emitter.send_account_state(account_state);

            self.await_account_registered(AX_ACCOUNT_REGISTRATION_TIMEOUT_SECS)
                .await?;

            let ws_orders = self.ws_orders.clone();
            self.session_tasks.spawn(run_auth_token_refresh(
                self.http_client.clone(),
                credential,
                move |token| ws_orders.update_auth_token(token.expose_secret()),
            ))?;
            Ok::<(), anyhow::Error>(())
        }
        .await;

        if let Err(e) = session_result {
            if let Err(teardown_error) = self.teardown_partial_connect().await {
                return Err(e.context(format!(
                    "AX execution startup teardown failed: {teardown_error}"
                )));
            }
            return Err(e);
        }

        self.core.set_connected();
        setup_guard.disarm();
        log::info!("Connected: client_id={}", self.core.client_id);
        Ok(())
    }

    async fn disconnect(&mut self) -> anyhow::Result<()> {
        self.abort_session_tasks();
        self.abort_pending_tasks();
        self.http_client.cancel_all_requests();

        let ws_result = self.ws_orders.close().await;
        let (session_result, pending_result) =
            tokio::join!(self.await_session_tasks(), self.await_pending_tasks());

        self.core.set_disconnected();
        ws_result?;
        session_result?;
        pending_result?;
        log::info!("Disconnected: client_id={}", self.core.client_id);
        Ok(())
    }

    fn query_account(&self, _cmd: QueryAccount) -> anyhow::Result<()> {
        self.update_account_state();
        Ok(())
    }

    fn query_order(&self, cmd: QueryOrder) -> anyhow::Result<()> {
        let http_client = self.http_client.clone();
        let account_id = self.core.account_id;
        let client_order_id = cmd.client_order_id;
        let venue_order_id = cmd.venue_order_id.or_else(|| {
            self.ws_orders
                .orders_metadata()
                .get(&client_order_id)
                .and_then(|metadata| metadata.venue_order_id)
        });
        let instrument_id = cmd.instrument_id;
        let emitter = self.emitter.clone();
        let caches = self.ws_orders.caches().clone();

        // Read immutable order fields from cache before spawning
        let (order_side, order_type, time_in_force) = {
            let cache = self.core.cache();
            match cache.order(&client_order_id) {
                Some(order) => (
                    Some(order.order_side()),
                    order.order_type(),
                    order.time_in_force(),
                ),
                None => (None, OrderType::Limit, TimeInForce::Gtc),
            }
        };

        self.spawn_task("query_order", async move {
            match http_client
                .request_order_status(
                    account_id,
                    instrument_id,
                    Some(client_order_id),
                    venue_order_id,
                    order_side,
                    order_type,
                    time_in_force,
                )
                .await
            {
                Ok(report) => {
                    cleanup_closed_order_status_report(&report, &caches);
                    emitter.send_order_status_report(report);
                }
                Err(e) => log::error!("AX query order failed: {e}"),
            }
            Ok(())
        });

        Ok(())
    }

    fn generate_account_state(
        &self,
        balances: Vec<AccountBalance>,
        margins: Vec<MarginBalance>,
        reported: bool,
        ts_event: UnixNanos,
        info: Option<Params>,
    ) -> anyhow::Result<()> {
        self.emitter
            .emit_account_state(balances, margins, reported, ts_event, info);
        Ok(())
    }

    fn start(&mut self) -> anyhow::Result<()> {
        if self.core.is_started() {
            return Ok(());
        }

        self.emitter.set_sender(get_exec_event_sender());
        self.core.set_started();
        log::info!(
            "Started: client_id={}, account_id={}, environment={}",
            self.core.client_id,
            self.core.account_id,
            self.config.environment,
        );
        Ok(())
    }

    fn stop(&mut self) -> anyhow::Result<()> {
        if self.core.is_stopped() {
            return Ok(());
        }

        self.core.set_stopped();
        self.core.set_disconnected();

        self.abort_session_tasks();
        self.abort_pending_tasks();
        log::info!("Stopped: client_id={}", self.core.client_id);
        Ok(())
    }

    fn reset(&mut self) -> anyhow::Result<()> {
        self.abort_session_tasks();
        self.abort_pending_tasks();
        self.core.set_disconnected();
        Ok(())
    }

    fn dispose(&mut self) -> anyhow::Result<()> {
        self.abort_session_tasks();
        self.abort_pending_tasks();
        self.core.set_disconnected();
        Ok(())
    }

    fn submit_order(&self, cmd: SubmitOrder) -> anyhow::Result<()> {
        {
            let cache = self.core.cache();
            let order = cache.try_order(&cmd.client_order_id)?;

            if order.is_closed() {
                log::warn!("Cannot submit closed order {}", order.client_order_id());
                return Ok(());
            }

            if let Err(e) = validate_order_for_ax_submit(&order)
                .and_then(|()| validate_order_init_instructions(&cmd.order_init))
            {
                self.emitter.emit_order_denied(&order, &e.to_string());
                return Ok(());
            }

            log::debug!("OrderSubmitted client_order_id={}", order.client_order_id());
            self.emitter.emit_order_submitted(&order);
        }

        self.submit_order_internal(&cmd)
    }

    fn submit_order_list(&self, cmd: SubmitOrderList) -> anyhow::Result<()> {
        for (client_order_id, order_init) in cmd
            .order_list
            .client_order_ids
            .iter()
            .zip(cmd.order_inits.iter())
        {
            let submit_cmd = SubmitOrder::new(
                cmd.trader_id,
                cmd.client_id,
                cmd.strategy_id,
                cmd.instrument_id,
                *client_order_id,
                order_init.clone(),
                cmd.exec_algorithm_id,
                cmd.position_id,
                cmd.params.clone(),
                UUID4::new(),
                cmd.ts_init,
                cmd.correlation_id,
            );
            self.submit_order(submit_cmd)?;
        }
        Ok(())
    }

    fn modify_order(&self, cmd: ModifyOrder) -> anyhow::Result<()> {
        if cmd.trigger_price.is_some() {
            emit_ax_modify_rejected(
                &self.emitter,
                self.clock,
                cmd.strategy_id,
                cmd.instrument_id,
                cmd.client_order_id,
                cmd.venue_order_id,
                "AX does not support venue-native trigger prices",
            );
            return Ok(());
        }

        let venue_order_id = match cmd.venue_order_id {
            Some(ref voi) => *voi,
            None => {
                emit_ax_modify_rejected(
                    &self.emitter,
                    self.clock,
                    cmd.strategy_id,
                    cmd.instrument_id,
                    cmd.client_order_id,
                    None,
                    "missing venue_order_id",
                );
                return Ok(());
            }
        };

        let quantity = match cmd.quantity {
            Some(quantity) => match quantity_to_contracts(quantity) {
                Ok(contracts) => Some(contracts),
                Err(e) => {
                    emit_ax_modify_rejected(
                        &self.emitter,
                        self.clock,
                        cmd.strategy_id,
                        cmd.instrument_id,
                        cmd.client_order_id,
                        Some(venue_order_id),
                        &e.to_string(),
                    );
                    return Ok(());
                }
            },
            None => None,
        };

        if !self.core.is_connected() {
            emit_ax_modify_rejected(
                &self.emitter,
                self.clock,
                cmd.strategy_id,
                cmd.instrument_id,
                cmd.client_order_id,
                Some(venue_order_id),
                "AX execution client is not connected",
            );
            return Ok(());
        }

        let http_client = self.http_client.clone();
        let emitter = self.emitter.clone();
        let clock = self.clock;
        let strategy_id = cmd.strategy_id;
        let instrument_id = cmd.instrument_id;
        let caches = self.ws_orders.caches().clone();
        let client_order_id = cmd.client_order_id;
        let price = cmd.price;

        self.spawn_task("modify_order", async move {
            let mut request = ReplaceOrderRequest::new(venue_order_id.as_str());

            if let Some(price) = price {
                request = request.with_price(price.as_decimal());
            }

            if let Some(contracts) = quantity {
                request = request.with_quantity(contracts);
            }

            match http_client.inner.replace_order(&request).await {
                Ok(resp) => {
                    let new_venue_order_id = match VenueOrderId::new_checked(&resp.oid) {
                        Ok(venue_order_id) => venue_order_id,
                        Err(e) => {
                            log::warn!(
                                "AX replace returned invalid venue order ID for {client_order_id}, awaiting reconciliation: {e}"
                            );
                            return Ok(());
                        }
                    };
                    record_replacement_venue_id(
                        &caches,
                        client_order_id,
                        new_venue_order_id,
                        false,
                    );
                    log::debug!("Order replaced: old={} new={}", request.oid, resp.oid);
                }
                // No replace failure is an unambiguous rejection (see
                // `classify_ax_http_failure`); leave the order pending.
                Err(e) => match classify_ax_http_failure(&e) {
                    CommandFailure::NotSent(reason) | CommandFailure::VenueRejected(reason) => {
                        emit_ax_modify_rejected(
                            &emitter,
                            clock,
                            strategy_id,
                            instrument_id,
                            client_order_id,
                            Some(venue_order_id),
                            &reason,
                        );
                    }
                    CommandFailure::Ambiguous(reason) => {
                        log::warn!(
                            "Ambiguous AX modify failure for {client_order_id}, awaiting reconciliation: {reason}"
                        );
                    }
                },
            }

            Ok(())
        });

        Ok(())
    }

    fn cancel_order(&self, cmd: CancelOrder) -> anyhow::Result<()> {
        self.cancel_order_internal(&cmd);
        Ok(())
    }

    fn cancel_all_orders(&self, cmd: CancelAllOrders) -> anyhow::Result<()> {
        let http_client = self.http_client.clone();
        let emitter = self.emitter.clone();
        let clock = self.clock;
        let instrument_id = cmd.instrument_id;
        let account_id = self.core.account_id;
        let trader_id = self.core.trader_id;

        // Snapshot open orders so we can emit cancel events after the HTTP request
        let open_orders: Vec<(ClientOrderId, Option<VenueOrderId>, StrategyId)> = {
            let cache = self.core.cache();
            cache
                .orders_open(None, Some(&instrument_id), None, None, None)
                .iter()
                .map(|o| (o.client_order_id(), o.venue_order_id(), o.strategy_id()))
                .collect()
        };

        let caches = self.ws_orders.caches().clone();

        self.spawn_task("cancel_all_orders", async move {
            match http_client.cancel_all_orders(instrument_id).await {
                Ok(()) => {
                    log::debug!("Canceled all orders for {instrument_id}");

                    // AX does not push WS cancel confirmations for HTTP-initiated
                    // cancels, so emit OrderCanceled events locally and clean up
                    // tracking state to prevent duplicates if WS events arrive
                    let ts_event = clock.get_time_ns();

                    for (client_order_id, venue_order_id, strategy_id) in &open_orders {
                        let event = OrderCanceled::new(
                            trader_id,
                            *strategy_id,
                            instrument_id,
                            *client_order_id,
                            UUID4::new(),
                            ts_event,
                            clock.get_time_ns(),
                            false,
                            *venue_order_id,
                            Some(account_id),
                            None,
                        );
                        emitter.send_order_event(OrderEventAny::Canceled(event));

                        if let Some(voi) = venue_order_id {
                            caches.venue_to_client_id.remove(voi);
                        }
                        caches.orders_metadata.remove(client_order_id);
                        caches
                            .cid_to_client_order_id
                            .retain(|_, mapped_client_order_id| {
                                mapped_client_order_id != client_order_id
                            });
                    }
                }
                // A whole-request failure has no per-order venue results and
                // must not fan out per-order rejections.
                Err(e) => match classify_ax_http_failure(&e) {
                    CommandFailure::NotSent(reason) | CommandFailure::VenueRejected(reason) => {
                        log::warn!("Cancel-all for {instrument_id} failed: {reason}");
                    }
                    CommandFailure::Ambiguous(reason) => {
                        log::warn!(
                            "Ambiguous AX cancel-all failure for {instrument_id}, awaiting reconciliation: {reason}"
                        );
                    }
                },
            }
            Ok(())
        });

        Ok(())
    }

    fn batch_cancel_orders(&self, cmd: BatchCancelOrders) -> anyhow::Result<()> {
        for cancel in &cmd.cancels {
            self.cancel_order_internal(cancel);
        }
        Ok(())
    }

    async fn generate_order_status_report(
        &self,
        cmd: &GenerateOrderStatusReport,
    ) -> anyhow::Result<Option<OrderStatusReport>> {
        let caches = self.ws_orders.caches().clone();
        let cid_map = caches.cid_to_client_order_id.clone();
        let cid_resolver = move |cid: u64| cid_map.get(&cid).map(|v| *v);

        let mut reports = self
            .http_client
            .request_order_status_reports(self.core.account_id, Some(cid_resolver))
            .await?;

        if let Some(instrument_id) = cmd.instrument_id {
            reports.retain(|report| report.instrument_id == instrument_id);
        }

        if let Some(client_order_id) = cmd.client_order_id {
            reports.retain(|report| report.client_order_id == Some(client_order_id));
        }

        if let Some(venue_order_id) = cmd.venue_order_id {
            reports.retain(|report| report.venue_order_id.as_str() == venue_order_id.as_str());
        }

        let report = reports.into_iter().next();
        if let Some(report) = &report {
            cleanup_closed_order_status_report(report, &caches);
        }

        Ok(report)
    }

    async fn generate_order_status_reports(
        &self,
        cmd: &GenerateOrderStatusReports,
    ) -> anyhow::Result<Vec<OrderStatusReport>> {
        let caches = self.ws_orders.caches().clone();
        let cid_map = caches.cid_to_client_order_id.clone();
        let cid_resolver = move |cid: u64| cid_map.get(&cid).map(|v| *v);

        let mut reports = if cmd.open_only {
            self.http_client
                .request_order_status_reports(self.core.account_id, Some(cid_resolver))
                .await?
        } else {
            self.http_client
                .request_historical_order_status_reports(
                    self.core.account_id,
                    cmd.start,
                    cmd.end,
                    Some(cid_resolver),
                )
                .await?
        };

        if let Some(instrument_id) = cmd.instrument_id {
            reports.retain(|report| report.instrument_id == instrument_id);
        }

        retain_order_status_reports(&mut reports, cmd);
        for report in &reports {
            cleanup_closed_order_status_report(report, &caches);
        }

        Ok(reports)
    }

    async fn generate_fill_reports(
        &self,
        cmd: GenerateFillReports,
    ) -> anyhow::Result<Vec<FillReport>> {
        let mut reports = self
            .http_client
            .request_fill_reports(self.core.account_id, cmd.start, cmd.end)
            .await?;

        if let Some(instrument_id) = cmd.instrument_id {
            reports.retain(|report| report.instrument_id == instrument_id);
        }

        if let Some(venue_order_id) = cmd.venue_order_id {
            reports.retain(|report| report.venue_order_id.as_str() == venue_order_id.as_str());
        }

        Ok(reports)
    }

    async fn generate_position_status_reports(
        &self,
        cmd: &GeneratePositionStatusReports,
    ) -> anyhow::Result<Vec<PositionStatusReport>> {
        let mut reports = self
            .http_client
            .request_position_reports(self.core.account_id)
            .await?;

        if let Some(instrument_id) = cmd.instrument_id {
            reports.retain(|report| report.instrument_id == instrument_id);
        }

        Ok(reports)
    }

    async fn generate_mass_status(
        &self,
        lookback_mins: Option<u64>,
    ) -> anyhow::Result<Option<ExecutionMassStatus>> {
        log::info!("Generating ExecutionMassStatus (lookback_mins={lookback_mins:?})");

        let ts_now = self.clock.get_time_ns();

        let start = lookback_mins
            .map(DurationNanos::try_from_mins)
            .transpose()?
            .map(|lookback| ts_now.saturating_sub(lookback));

        let order_cmd = GenerateOrderStatusReports::new(
            UUID4::new(),
            ts_now,
            false, // open_only
            None,  // instrument_id
            start,
            None, // end
            None, // params
            None, // correlation_id
        );

        let fill_cmd = GenerateFillReports::new(
            UUID4::new(),
            ts_now,
            None, // instrument_id
            None, // venue_order_id
            start,
            None, // end
            None, // params
            None, // correlation_id
        );

        let position_cmd = GeneratePositionStatusReports::new(
            UUID4::new(),
            ts_now,
            None, // instrument_id
            start,
            None, // end
            None, // params
            None, // correlation_id
        );

        let (order_reports, fill_reports, position_reports) = tokio::try_join!(
            self.generate_order_status_reports(&order_cmd),
            self.generate_fill_reports(fill_cmd),
            self.generate_position_status_reports(&position_cmd),
        )?;

        log::info!("Received {} OrderStatusReports", order_reports.len());
        log::info!("Received {} FillReports", fill_reports.len());
        log::info!("Received {} PositionReports", position_reports.len());

        let mut mass_status = ExecutionMassStatus::new(
            self.core.client_id,
            self.core.account_id,
            *AX_VENUE,
            ts_now,
            None,
        );

        mass_status.add_order_reports(order_reports);
        mass_status.add_fill_reports(fill_reports);
        mass_status.add_position_reports(position_reports);

        Ok(Some(mass_status))
    }

    fn register_external_order(
        &self,
        client_order_id: ClientOrderId,
        venue_order_id: VenueOrderId,
        instrument_id: InstrumentId,
        strategy_id: StrategyId,
        _ts_init: UnixNanos,
    ) {
        self.ws_orders.register_external_order(
            client_order_id,
            venue_order_id,
            instrument_id,
            strategy_id,
        );
    }
}

fn emit_ax_modify_rejected(
    emitter: &ExecutionEventEmitter,
    clock: &'static AtomicTime,
    strategy_id: StrategyId,
    instrument_id: InstrumentId,
    client_order_id: ClientOrderId,
    venue_order_id: Option<VenueOrderId>,
    reason: &str,
) {
    log::warn!("Modify command failed local validation for {client_order_id}: {reason}");
    emitter.emit_order_modify_rejected_event(
        strategy_id,
        instrument_id,
        client_order_id,
        venue_order_id,
        reason,
        clock.get_time_ns(),
    );
}

/// Dispatches a WebSocket message using the event emitter.
fn dispatch_ws_message(
    message: AxOrdersWsMessage,
    emitter: &ExecutionEventEmitter,
    caches: &OrdersCaches,
    account_id: AccountId,
    instruments: &AtomicMap<Ustr, InstrumentAny>,
    clock: &'static AtomicTime,
) {
    match message {
        AxOrdersWsMessage::Event(event) => {
            dispatch_order_event(*event, emitter, caches, account_id, instruments, clock);
        }
        AxOrdersWsMessage::PlaceOrderResponse(resp) => {
            log::debug!(
                "Place order response: rid={} oid={}",
                resp.rid,
                resp.res.oid
            );
        }
        AxOrdersWsMessage::CancelOrderResponse(resp) => {
            log::debug!(
                "Cancel order response: rid={} accepted={}",
                resp.rid,
                resp.res.cxl_rx
            );
        }
        AxOrdersWsMessage::OpenOrdersResponse(resp) => {
            log::debug!("Open orders response: {} orders", resp.res.orders.len());
        }
        AxOrdersWsMessage::Error(err) => {
            log::warn!("WebSocket error: {}", err.message);
        }
        AxOrdersWsMessage::Reconnected => {
            log::info!("WebSocket reconnected");
        }
        AxOrdersWsMessage::Authenticated => {
            log::debug!("WebSocket authenticated");
        }
    }
}

fn dispatch_order_event(
    event: AxWsOrderEvent,
    emitter: &ExecutionEventEmitter,
    caches: &OrdersCaches,
    account_id: AccountId,
    instruments: &AtomicMap<Ustr, InstrumentAny>,
    clock: &'static AtomicTime,
) {
    match event {
        AxWsOrderEvent::Heartbeat => {}
        AxWsOrderEvent::Acknowledged(msg) => {
            if let Some(event) =
                create_order_accepted(&msg.o, msg.ts, msg.tn, caches, account_id, clock)
            {
                emitter.send_order_event(OrderEventAny::Accepted(event));
            } else if let Some(report) = create_order_status_report(
                &msg.o,
                OrderStatus::Accepted,
                msg.ts,
                msg.tn,
                caches,
                account_id,
                instruments,
                clock,
            ) {
                emitter.send_order_status_report(report);
            }
        }
        AxWsOrderEvent::PartiallyFilled(msg) => {
            dispatch_fill_event(
                &msg.o,
                &msg.xs,
                msg.ts,
                msg.tn,
                emitter,
                caches,
                account_id,
                instruments,
                clock,
            );
        }
        AxWsOrderEvent::Filled(msg) => {
            dispatch_fill_event(
                &msg.o,
                &msg.xs,
                msg.ts,
                msg.tn,
                emitter,
                caches,
                account_id,
                instruments,
                clock,
            );
            cleanup_terminal_order_tracking(&msg.o, caches);
        }
        AxWsOrderEvent::Canceled(msg) => {
            if let Some(event) =
                create_order_canceled(&msg.o, msg.ts, msg.tn, caches, account_id, clock)
            {
                emitter.send_order_event(OrderEventAny::Canceled(event));
            } else if let Some(report) = create_order_status_report(
                &msg.o,
                OrderStatus::Canceled,
                msg.ts,
                msg.tn,
                caches,
                account_id,
                instruments,
                clock,
            ) {
                emitter.send_order_status_report(report);
            }
            cleanup_terminal_order_tracking(&msg.o, caches);
        }
        AxWsOrderEvent::Rejected(msg) => {
            let known_reason = msg.r.filter(|r| !matches!(r, AxOrderRejectReason::Unknown));
            let reason = known_reason
                .as_ref()
                .map(AsRef::as_ref)
                .or(msg.txt.as_deref())
                .unwrap_or("UNKNOWN");

            if let Some(event) =
                create_order_rejected(&msg.o, reason, msg.ts, msg.tn, caches, account_id, clock)
            {
                emitter.send_order_event(OrderEventAny::Rejected(event));
            }
            cleanup_terminal_order_tracking(&msg.o, caches);
        }
        AxWsOrderEvent::Expired(msg) => {
            // AX reports an unfilled IOC/FOK as EXPIRED; Nautilus models those as canceled
            let as_canceled = matches!(msg.o.tif, AxTimeInForce::Ioc | AxTimeInForce::Fok);
            let event = if as_canceled {
                create_order_canceled(&msg.o, msg.ts, msg.tn, caches, account_id, clock)
                    .map(OrderEventAny::Canceled)
            } else {
                create_order_expired(&msg.o, msg.ts, msg.tn, caches, account_id, clock)
                    .map(OrderEventAny::Expired)
            };

            if let Some(event) = event {
                emitter.send_order_event(event);
            } else if let Some(report) = create_order_status_report(
                &msg.o,
                if as_canceled {
                    OrderStatus::Canceled
                } else {
                    OrderStatus::Expired
                },
                msg.ts,
                msg.tn,
                caches,
                account_id,
                instruments,
                clock,
            ) {
                emitter.send_order_status_report(report);
            }
            cleanup_terminal_order_tracking(&msg.o, caches);
        }
        AxWsOrderEvent::Replaced(msg) => {
            let replacement_venue_order_id = match replacement_venue_order_id(&msg) {
                Ok(venue_order_id) => venue_order_id,
                Err(e) => {
                    log::warn!("Invalid AX replace event, awaiting reconciliation: {e}");
                    return;
                }
            };

            if let Some(event) = create_order_updated(
                &msg.no,
                &msg.ro,
                replacement_venue_order_id,
                (msg.ts, msg.tn),
                caches,
                account_id,
                clock,
            ) {
                emitter.send_order_event(OrderEventAny::Updated(event));
            } else if let Some(report) = create_order_status_report(
                &msg.no,
                OrderStatus::Accepted,
                msg.ts,
                msg.tn,
                caches,
                account_id,
                instruments,
                clock,
            ) {
                emitter.send_order_status_report(report);
            }
        }
        AxWsOrderEvent::DoneForDay(msg) => {
            if let Some(event) =
                create_order_expired(&msg.o, msg.ts, msg.tn, caches, account_id, clock)
            {
                emitter.send_order_event(OrderEventAny::Expired(event));
            } else if let Some(report) = create_order_status_report(
                &msg.o,
                OrderStatus::Expired,
                msg.ts,
                msg.tn,
                caches,
                account_id,
                instruments,
                clock,
            ) {
                emitter.send_order_status_report(report);
            }
            cleanup_terminal_order_tracking(&msg.o, caches);
        }
        AxWsOrderEvent::CancelRejected(msg) => {
            let venue_order_id = VenueOrderId::new(&msg.oid);
            if let Some(client_order_id) = caches.venue_to_client_id.get(&venue_order_id)
                && let Some(metadata) = caches.orders_metadata.get(&client_order_id)
            {
                let event = OrderCancelRejected::new(
                    metadata.trader_id,
                    metadata.strategy_id,
                    metadata.instrument_id,
                    metadata.client_order_id,
                    Ustr::from(msg.r.as_ref()),
                    UUID4::new(),
                    clock.get_time_ns(),
                    metadata.ts_init,
                    false,
                    Some(venue_order_id),
                    Some(account_id),
                );
                emitter.send_order_event(OrderEventAny::CancelRejected(event));
            } else {
                log::warn!(
                    "Could not find metadata for cancel rejected order {}",
                    msg.oid
                );
            }
        }
    }
}

#[expect(clippy::too_many_arguments)]
fn dispatch_fill_event(
    order: &AxWsOrder,
    execution: &AxWsTradeExecution,
    ts: i64,
    tn: i64,
    emitter: &ExecutionEventEmitter,
    caches: &OrdersCaches,
    account_id: AccountId,
    instruments: &AtomicMap<Ustr, InstrumentAny>,
    clock: &'static AtomicTime,
) {
    if let Some(event) = create_order_filled(order, execution, ts, tn, caches, account_id, clock) {
        emitter.send_order_event(OrderEventAny::Filled(event));
    } else if let Some(report) = create_fill_report(
        order,
        execution,
        ts,
        tn,
        caches,
        account_id,
        instruments,
        clock,
    ) {
        emitter.send_fill_report(report);
    }
}

pub(crate) fn lookup_order_metadata<'a>(
    order: &AxWsOrder,
    caches: &'a OrdersCaches,
) -> Option<dashmap::mapref::one::Ref<'a, ClientOrderId, OrderMetadata>> {
    let venue_order_id = VenueOrderId::new(&order.oid);

    if let Some(client_order_id) = caches.venue_to_client_id.get(&venue_order_id)
        && let Some(metadata) = caches.orders_metadata.get(&*client_order_id)
    {
        return Some(metadata);
    }

    if let Some(cid) = order.cid
        && let Some(client_order_id) = caches.cid_to_client_order_id.get(&cid)
        && let Some(metadata) = caches.orders_metadata.get(&*client_order_id)
    {
        return Some(metadata);
    }

    None
}

pub(crate) fn replacement_venue_order_id(
    message: &crate::websocket::messages::AxWsOrderReplaced,
) -> anyhow::Result<VenueOrderId> {
    if message.noid != message.no.oid {
        anyhow::bail!(
            "noid '{}' does not match new order oid '{}'",
            message.noid,
            message.no.oid
        );
    }

    VenueOrderId::new_checked(&message.noid).map_err(anyhow::Error::from)
}

pub(crate) fn create_order_accepted(
    order: &AxWsOrder,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    clock: &'static AtomicTime,
) -> Option<OrderAccepted> {
    let venue_order_id = VenueOrderId::new(&order.oid);
    let metadata = lookup_order_metadata(order, caches)?;

    let client_order_id = metadata.client_order_id;
    let trader_id = metadata.trader_id;
    let strategy_id = metadata.strategy_id;
    let instrument_id = metadata.instrument_id;
    drop(metadata);

    caches
        .venue_to_client_id
        .insert(venue_order_id, client_order_id);

    if let Some(mut entry) = caches.orders_metadata.get_mut(&client_order_id) {
        entry.venue_order_id = Some(venue_order_id);
    }

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;

    Some(OrderAccepted::new(
        trader_id,
        strategy_id,
        instrument_id,
        client_order_id,
        venue_order_id,
        account_id,
        UUID4::new(),
        ts_event,
        clock.get_time_ns(),
        false,
    ))
}

pub(crate) fn create_order_updated(
    order: &AxWsOrder,
    replaced_order: &AxWsOrder,
    replacement_venue_order_id: VenueOrderId,
    event_timestamp: (i64, i64),
    caches: &OrdersCaches,
    account_id: AccountId,
    clock: &'static AtomicTime,
) -> Option<OrderUpdated> {
    let metadata = lookup_order_metadata(order, caches)
        .or_else(|| lookup_order_metadata(replaced_order, caches))?;

    let client_order_id = metadata.client_order_id;
    let trader_id = metadata.trader_id;
    let strategy_id = metadata.strategy_id;
    let instrument_id = metadata.instrument_id;
    let price_precision = metadata.price_precision;
    let size_precision = metadata.size_precision;
    drop(metadata);

    record_replacement_venue_id(caches, client_order_id, replacement_venue_order_id, true);

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_timestamp.0, event_timestamp.1)
        .map_err(|e| log::error!("{e}"))
        .ok()?;

    let quantity = Quantity::new(order.q as f64, size_precision);
    let price = Price::from_decimal_dp(order.p, price_precision).ok();

    Some(OrderUpdated::new(
        trader_id,
        strategy_id,
        instrument_id,
        client_order_id,
        quantity,
        UUID4::new(),
        ts_event,
        clock.get_time_ns(),
        false,
        Some(replacement_venue_order_id),
        Some(account_id),
        price,
        None, // trigger_price
        None, // protection_price
        false,
    ))
}

pub(crate) fn create_order_filled(
    order: &AxWsOrder,
    execution: &AxWsTradeExecution,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    clock: &'static AtomicTime,
) -> Option<OrderFilled> {
    let venue_order_id = VenueOrderId::new(&order.oid);
    let metadata = lookup_order_metadata(order, caches)?;

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;

    let last_qty = Quantity::new(execution.q as f64, metadata.size_precision);
    let last_px = Price::from_decimal_dp(execution.p, metadata.price_precision).ok()?;

    let order_side = OrderSide::from(order.d);

    let liquidity_side = if execution.agg {
        LiquiditySide::Taker
    } else {
        LiquiditySide::Maker
    };

    Some(OrderFilled::new(
        metadata.trader_id,
        metadata.strategy_id,
        metadata.instrument_id,
        metadata.client_order_id,
        venue_order_id,
        account_id,
        TradeId::new(&execution.tid),
        order_side,
        OrderType::Limit,
        last_qty,
        last_px,
        metadata.quote_currency,
        liquidity_side,
        UUID4::new(),
        ts_event,
        clock.get_time_ns(),
        false,
        None,
        None,
        None,
    ))
}

pub(crate) fn create_order_canceled(
    order: &AxWsOrder,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    clock: &'static AtomicTime,
) -> Option<OrderCanceled> {
    let venue_order_id = VenueOrderId::new(&order.oid);
    let metadata = lookup_order_metadata(order, caches)?;

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;

    Some(OrderCanceled::new(
        metadata.trader_id,
        metadata.strategy_id,
        metadata.instrument_id,
        metadata.client_order_id,
        UUID4::new(),
        ts_event,
        clock.get_time_ns(),
        false,
        Some(venue_order_id),
        Some(account_id),
        None,
    ))
}

pub(crate) fn create_order_expired(
    order: &AxWsOrder,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    clock: &'static AtomicTime,
) -> Option<OrderExpired> {
    let venue_order_id = VenueOrderId::new(&order.oid);
    let metadata = lookup_order_metadata(order, caches)?;

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;

    Some(OrderExpired::new(
        metadata.trader_id,
        metadata.strategy_id,
        metadata.instrument_id,
        metadata.client_order_id,
        UUID4::new(),
        ts_event,
        clock.get_time_ns(),
        false,
        Some(venue_order_id),
        Some(account_id),
    ))
}

pub(crate) fn create_order_rejected(
    order: &AxWsOrder,
    reason: &str,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    clock: &'static AtomicTime,
) -> Option<OrderRejected> {
    let metadata = lookup_order_metadata(order, caches)?;

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;
    let due_post_only = reason.contains(AX_POST_ONLY_REJECT);

    Some(OrderRejected::new(
        metadata.trader_id,
        metadata.strategy_id,
        metadata.instrument_id,
        metadata.client_order_id,
        account_id,
        Ustr::from(reason),
        UUID4::new(),
        ts_event,
        clock.get_time_ns(),
        false,
        due_post_only,
    ))
}

fn cleanup_closed_order_status_report(report: &OrderStatusReport, caches: &OrdersCaches) {
    if !report.order_status.is_closed() {
        return;
    }

    cleanup_terminal_order_tracking_ids(
        caches,
        Some(&report.venue_order_id),
        report.client_order_id.as_ref().map(client_order_id_to_cid),
        report.client_order_id,
    );
}

pub(crate) fn cleanup_terminal_order_tracking(order: &AxWsOrder, caches: &OrdersCaches) {
    let venue_order_id = VenueOrderId::new(&order.oid);
    cleanup_terminal_order_tracking_ids(caches, Some(&venue_order_id), order.cid, None);
}

fn cleanup_terminal_order_tracking_ids(
    caches: &OrdersCaches,
    venue_order_id: Option<&VenueOrderId>,
    cid: Option<u64>,
    known_client_order_id: Option<ClientOrderId>,
) {
    let client_order_id = venue_order_id
        .and_then(|venue_order_id| {
            caches
                .venue_to_client_id
                .remove(venue_order_id)
                .map(|(_, v)| v)
        })
        .or_else(|| cid.and_then(|cid| caches.cid_to_client_order_id.remove(&cid).map(|(_, v)| v)))
        .or(known_client_order_id);

    if let Some(client_order_id) = client_order_id {
        caches.orders_metadata.remove(&client_order_id);
        caches
            .venue_to_client_id
            .retain(|_, mapped_client_order_id| *mapped_client_order_id != client_order_id);
        caches
            .cid_to_client_order_id
            .retain(|_, mapped_client_order_id| *mapped_client_order_id != client_order_id);
    }

    if let Some(cid) = cid {
        caches.cid_to_client_order_id.remove(&cid);
    }
}

fn record_replacement_venue_id(
    caches: &OrdersCaches,
    client_order_id: ClientOrderId,
    venue_order_id: VenueOrderId,
    remove_previous_venue_ids: bool,
) {
    caches
        .venue_to_client_id
        .insert(venue_order_id, client_order_id);
    if let Some(mut entry) = caches.orders_metadata.get_mut(&client_order_id) {
        entry.venue_order_id = Some(venue_order_id);
    }

    if remove_previous_venue_ids {
        caches
            .venue_to_client_id
            .retain(|mapped_venue_order_id, mapped_client_order_id| {
                *mapped_client_order_id != client_order_id
                    || *mapped_venue_order_id == venue_order_id
            });
    }
}

#[expect(clippy::too_many_arguments)]
fn create_order_status_report(
    order: &AxWsOrder,
    order_status: OrderStatus,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    instruments: &AtomicMap<Ustr, InstrumentAny>,
    clock: &'static AtomicTime,
) -> Option<OrderStatusReport> {
    let instruments_snap = instruments.load();
    let instrument = instruments_snap.get(&order.s)?;
    let venue_order_id = VenueOrderId::new(&order.oid);
    let instrument_id = instrument.id();
    let order_side = OrderSide::from(order.d);
    let time_in_force = order.tif.into();

    let quantity = Quantity::new(order.q as f64, instrument.size_precision());
    let filled_qty = Quantity::new(order.xq as f64, instrument.size_precision());

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;
    let ts_init = clock.get_time_ns();

    let client_order_id = order.cid.map(|cid| {
        caches
            .cid_to_client_order_id
            .get(&cid)
            .map_or_else(|| cid_to_client_order_id(cid), |v| *v)
    });

    let mut report = OrderStatusReport::new(
        account_id,
        instrument_id,
        client_order_id,
        venue_order_id,
        order_side.into(),
        OrderType::Limit,
        time_in_force,
        order_status,
        quantity,
        filled_qty,
        ts_event,
        ts_event,
        ts_init,
        Some(UUID4::new()),
    );

    if let Ok(price) = Price::from_decimal_dp(order.p, instrument.price_precision()) {
        report = report.with_price(price);
    }

    Some(report)
}

#[expect(clippy::too_many_arguments)]
fn create_fill_report(
    order: &AxWsOrder,
    execution: &AxWsTradeExecution,
    event_ts: i64,
    event_tn: i64,
    caches: &OrdersCaches,
    account_id: AccountId,
    instruments: &AtomicMap<Ustr, InstrumentAny>,
    clock: &'static AtomicTime,
) -> Option<FillReport> {
    let instruments_snap = instruments.load();
    let instrument = instruments_snap.get(&order.s)?;
    let venue_order_id = VenueOrderId::new(&order.oid);
    let instrument_id = instrument.id();
    let order_side = order.d.into();

    let last_qty = Quantity::new(execution.q as f64, instrument.size_precision());
    let last_px = Price::from_decimal_dp(execution.p, instrument.price_precision()).ok()?;

    let liquidity_side = if execution.agg {
        LiquiditySide::Taker
    } else {
        LiquiditySide::Maker
    };

    let ts_event = ax_timestamp_stn_to_unix_nanos(event_ts, event_tn)
        .map_err(|e| log::error!("{e}"))
        .ok()?;
    let ts_init = clock.get_time_ns();

    let client_order_id = order.cid.map(|cid| {
        caches
            .cid_to_client_order_id
            .get(&cid)
            .map_or_else(|| cid_to_client_order_id(cid), |v| *v)
    });

    // The WS trade execution payload does not include fee data so
    // commission is zero here. The REST /fills endpoint (used during
    // reconciliation via parse_fill_report) includes accurate fees.
    let commission = Money::zero(instrument.quote_currency());

    Some(FillReport::new(
        account_id,
        instrument_id,
        venue_order_id,
        TradeId::new(&execution.tid),
        order_side,
        last_qty,
        last_px,
        commission,
        liquidity_side,
        client_order_id,
        None,
        ts_event,
        ts_init,
        Some(UUID4::new()),
    ))
}

fn validate_order_for_ax_submit(order: &OrderAny) -> anyhow::Result<()> {
    if !matches!(order.order_type(), OrderType::Market | OrderType::Limit) {
        anyhow::bail!(
            "Unsupported order type: {:?}, the Architect AX adapter accepts Nautilus MARKET and LIMIT orders",
            order.order_type(),
        );
    }

    // AX accepts only GTC, IOC, and DAY; deny others locally to avoid an opaque venue error
    if !matches!(
        order.time_in_force(),
        TimeInForce::Gtc | TimeInForce::Ioc | TimeInForce::Day
    ) {
        anyhow::bail!(
            "Unsupported time in force: {:?}, AX supports GTC, IOC, and DAY",
            order.time_in_force(),
        );
    }

    validate_order_instructions(
        order.is_reduce_only(),
        order.is_quote_quantity(),
        order.display_qty().is_some(),
    )?;

    quantity_to_contracts(order.quantity())?;

    Ok(())
}

fn validate_order_init_instructions(order_init: &OrderInitialized) -> anyhow::Result<()> {
    validate_order_instructions(
        order_init.reduce_only,
        order_init.quote_quantity,
        order_init.display_qty.is_some(),
    )
}

fn validate_order_instructions(
    reduce_only: bool,
    quote_quantity: bool,
    has_display_qty: bool,
) -> anyhow::Result<()> {
    if reduce_only {
        anyhow::bail!("AX does not support reduce-only orders");
    }

    if quote_quantity {
        anyhow::bail!(
            "Architect AX adapter cannot encode quote_quantity; submit a base quantity instead"
        );
    }

    if has_display_qty {
        anyhow::bail!("Architect AX adapter cannot encode display_qty iceberg instructions");
    }

    Ok(())
}

// The AX HTTP API documents only a bare 400 with no error schema, so no venue
// failure can be allowlisted as an unambiguous rejection; those arrive via the
// orders WS `Rejected` and `CancelRejected` events instead. AX therefore never
// classifies a send failure as `CommandFailure::VenueRejected`.
fn classify_ax_http_failure(error: &AxHttpError) -> CommandFailure {
    let message = error.to_string();
    match error {
        AxHttpError::MissingCredentials
        | AxHttpError::MissingSessionToken
        | AxHttpError::ValidationError(_)
        | AxHttpError::BuildError(_) => CommandFailure::NotSent(message),
        AxHttpError::ApiError { .. }
        | AxHttpError::JsonError(_)
        | AxHttpError::Canceled(_)
        | AxHttpError::NetworkError(_)
        | AxHttpError::UnexpectedStatus { .. } => CommandFailure::Ambiguous(message),
    }
}

fn classify_ax_ws_failure(error: &AxOrdersWsClientError) -> CommandFailure {
    match error {
        AxOrdersWsClientError::ClientError(message) => CommandFailure::NotSent(message.clone()),
        AxOrdersWsClientError::Transport(_)
        | AxOrdersWsClientError::ChannelError(_)
        | AxOrdersWsClientError::AuthenticationError(_) => {
            CommandFailure::Ambiguous(error.to_string())
        }
    }
}

#[cfg(test)]
mod tests {
    use std::{cell::RefCell, net::SocketAddr, rc::Rc, sync::Arc, time::Duration};

    use dashmap::DashMap;
    use nautilus_common::{cache::Cache, messages::ExecutionEvent};
    use nautilus_core::time::get_atomic_clock_realtime;
    use nautilus_live::ExecutionClientCore;
    use nautilus_model::{
        enums::AssetClass,
        identifiers::{
            AccountId, ClientOrderId, InstrumentId, StrategyId, Symbol, TraderId, VenueOrderId,
        },
        instruments::{InstrumentAny, PerpetualContract},
        orders::builder::OrderTestBuilder,
        types::{Currency, Price, Quantity},
    };
    use rstest::rstest;
    use rust_decimal::Decimal;
    use rust_decimal_macros::dec;
    use ustr::Ustr;

    use super::*;
    use crate::{
        common::{
            consts::{AX_CLIENT_ID, AX_VENUE},
            enums::{AxEnvironment, AxOrderSide, AxOrderStatus, AxTimeInForce},
        },
        config::AxExecutionClientConfig,
        http::error::AxBuildError,
        websocket::{
            messages::{AxWsOrderExpired, AxWsTradeExecution, OrderMetadata},
            orders::OrdersCaches,
        },
    };

    fn test_caches() -> OrdersCaches {
        OrdersCaches {
            orders_metadata: Arc::new(DashMap::new()),
            venue_to_client_id: Arc::new(DashMap::new()),
            cid_to_client_order_id: Arc::new(DashMap::new()),
        }
    }

    fn test_ws_order(oid: &str, price: Decimal, qty: u64) -> AxWsOrder {
        AxWsOrder {
            oid: oid.to_string(),
            u: "user".to_string(),
            s: Ustr::from("BTC-PERP"),
            p: price,
            q: qty,
            xq: 0,
            rq: qty,
            o: AxOrderStatus::Accepted,
            d: AxOrderSide::Buy,
            tif: AxTimeInForce::Gtc,
            ts: 1609459200,
            tn: 0,
            cid: None,
            tag: None,
            txt: None,
        }
    }

    #[rstest]
    fn test_create_order_updated_uses_ws_replacement_id_before_http_response() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-WS-FIRST");
        let old_venue_order_id = VenueOrderId::new("OLD-OID");
        let new_venue_order_id = VenueOrderId::new("NEW-OID");

        let mut metadata = test_metadata(client_order_id, InstrumentId::from("BTC-PERP.AX"));
        metadata.venue_order_id = Some(old_venue_order_id);
        caches.orders_metadata.insert(client_order_id, metadata);
        caches
            .venue_to_client_id
            .insert(old_venue_order_id, client_order_id);

        let old_order = test_ws_order(old_venue_order_id.as_str(), dec!(50000.00), 100);
        let new_order = test_ws_order(new_venue_order_id.as_str(), dec!(50001.00), 100);
        let event = create_order_updated(
            &new_order,
            &old_order,
            new_venue_order_id,
            (1609459200, 0),
            &caches,
            account_id,
            clock,
        )
        .expect("should produce OrderUpdated");

        assert_eq!(event.venue_order_id, Some(new_venue_order_id));
        assert_eq!(
            caches
                .orders_metadata
                .get(&client_order_id)
                .unwrap()
                .venue_order_id,
            Some(new_venue_order_id),
        );
        assert!(!caches.venue_to_client_id.contains_key(&old_venue_order_id));
        assert_eq!(
            *caches.venue_to_client_id.get(&new_venue_order_id).unwrap(),
            client_order_id,
        );
    }

    #[rstest]
    fn test_record_http_replacement_retains_previous_venue_id_until_ws_event() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-HTTP-FIRST");
        let old_venue_order_id = VenueOrderId::new("OLD-OID");
        let new_venue_order_id = VenueOrderId::new("NEW-OID");
        let mut metadata = test_metadata(client_order_id, InstrumentId::from("BTC-PERP.AX"));
        metadata.venue_order_id = Some(old_venue_order_id);
        caches.orders_metadata.insert(client_order_id, metadata);
        caches
            .venue_to_client_id
            .insert(old_venue_order_id, client_order_id);

        record_replacement_venue_id(&caches, client_order_id, new_venue_order_id, false);

        assert!(caches.venue_to_client_id.contains_key(&old_venue_order_id));
        assert!(caches.venue_to_client_id.contains_key(&new_venue_order_id));
        assert_eq!(
            caches
                .orders_metadata
                .get(&client_order_id)
                .unwrap()
                .venue_order_id,
            Some(new_venue_order_id),
        );

        record_replacement_venue_id(&caches, client_order_id, new_venue_order_id, true);

        assert!(!caches.venue_to_client_id.contains_key(&old_venue_order_id));
        assert!(caches.venue_to_client_id.contains_key(&new_venue_order_id));
    }

    fn test_metadata(client_order_id: ClientOrderId, instrument_id: InstrumentId) -> OrderMetadata {
        OrderMetadata {
            trader_id: TraderId::from("TRADER-001"),
            strategy_id: StrategyId::from("S-001"),
            instrument_id,
            client_order_id,
            venue_order_id: None,
            ts_init: 0.into(),
            size_precision: 0,
            price_precision: 2,
            quote_currency: Currency::USD(),
        }
    }

    fn test_execution(tid: &str, price: Decimal, qty: u64, agg: bool) -> AxWsTradeExecution {
        AxWsTradeExecution {
            tid: tid.to_string(),
            s: Ustr::from("BTC-PERP"),
            q: qty,
            p: price,
            d: AxOrderSide::Buy,
            agg,
        }
    }

    fn seed_terminal_tracking(
        caches: &OrdersCaches,
        client_order_id: ClientOrderId,
        venue_order_id: VenueOrderId,
        stale_venue_order_id: VenueOrderId,
        cid_value: u64,
    ) {
        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, InstrumentId::from("BTC-PERP.AX")),
        );
        caches
            .venue_to_client_id
            .insert(venue_order_id, client_order_id);
        caches
            .venue_to_client_id
            .insert(stale_venue_order_id, client_order_id);
        caches
            .cid_to_client_order_id
            .insert(cid_value, client_order_id);
    }

    fn test_perp_instrument(symbol: &str) -> InstrumentAny {
        let symbol = Symbol::new(symbol);
        let instrument = PerpetualContract::builder()
            .instrument_id(InstrumentId::new(symbol, *AX_VENUE))
            .raw_symbol(symbol)
            .underlying(Ustr::from("BTC"))
            .asset_class(AssetClass::Cryptocurrency)
            .quote_currency(Currency::USD())
            .settlement_currency(Currency::USD())
            .is_inverse(false)
            .price_precision(2)
            .size_precision(0)
            .price_increment(Price::from("0.01"))
            .size_increment(Quantity::from("1"))
            .margin_init(Decimal::new(1, 2))
            .margin_maint(Decimal::new(5, 3))
            .maker_fee(Decimal::new(2, 4))
            .taker_fee(Decimal::new(5, 4))
            .ts_event(0.into())
            .ts_init(0.into())
            .build()
            .unwrap();
        InstrumentAny::PerpetualContract(instrument)
    }

    async fn start_orders_report_server(body: serde_json::Value) -> SocketAddr {
        let listener = tokio::net::TcpListener::bind("127.0.0.1:0")
            .await
            .expect("bind report server");
        let addr = listener.local_addr().expect("report server addr");

        tokio::spawn(async move {
            let app = axum::Router::new().route(
                "/orders",
                axum::routing::get(move || async { axum::Json(body) }),
            );
            axum::serve(listener, app).await.unwrap();
        });

        for _ in 0..50 {
            if tokio::net::TcpStream::connect(addr).await.is_ok() {
                break;
            }

            tokio::time::sleep(Duration::from_millis(10)).await;
        }

        addr
    }

    fn test_status_report(
        client_order_id: Option<ClientOrderId>,
        venue_order_id: VenueOrderId,
        order_status: OrderStatus,
    ) -> OrderStatusReport {
        OrderStatusReport::new(
            AccountId::from("AX-001"),
            InstrumentId::from("BTC-PERP.AX"),
            client_order_id,
            venue_order_id,
            Some(OrderSide::Buy),
            OrderType::Limit,
            TimeInForce::Gtc,
            order_status,
            Quantity::from("1"),
            Quantity::from("1"),
            0.into(),
            0.into(),
            0.into(),
            None,
        )
    }

    #[rstest]
    fn test_create_order_accepted_populates_cache_and_event() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-ACK");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        let venue_order_id = VenueOrderId::new("OID-ACK");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        let cid_value = 7u64;
        caches
            .cid_to_client_order_id
            .insert(cid_value, client_order_id);

        let mut ws_order = test_ws_order(venue_order_id.as_str(), dec!(50500.00), 100);
        ws_order.cid = Some(cid_value);

        let event = create_order_accepted(&ws_order, 1609459200, 500, &caches, account_id, clock)
            .expect("should produce OrderAccepted");

        assert_eq!(event.venue_order_id, venue_order_id);
        assert_eq!(event.client_order_id, client_order_id);
        assert_eq!(event.account_id, account_id);
        assert_eq!(event.instrument_id, instrument_id);
        assert_eq!(event.trader_id, TraderId::from("TRADER-001"));
        assert_eq!(event.strategy_id, StrategyId::from("S-001"));
        assert_eq!(
            event.ts_event,
            UnixNanos::from(1_609_459_200_000_000_500u64)
        );

        // Side effects on caches
        assert_eq!(
            *caches.venue_to_client_id.get(&venue_order_id).unwrap(),
            client_order_id,
        );
        let meta = caches.orders_metadata.get(&client_order_id).unwrap();
        assert_eq!(meta.venue_order_id, Some(venue_order_id));
    }

    #[rstest]
    fn test_create_order_accepted_returns_none_without_metadata() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let ws_order = test_ws_order("OID-UNKNOWN", dec!(100.00), 10);

        let result = create_order_accepted(&ws_order, 1609459200, 0, &caches, account_id, clock);
        assert!(result.is_none());
        assert!(caches.venue_to_client_id.is_empty());
    }

    #[rstest]
    fn test_lookup_order_metadata_cid_fallback() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-CID");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches.cid_to_client_order_id.insert(99, client_order_id);

        let mut ws_order = test_ws_order("UNKNOWN-OID", dec!(0), 0);
        ws_order.cid = Some(99);

        let found = lookup_order_metadata(&ws_order, &caches).expect("cid fallback should find");
        assert_eq!(found.client_order_id, client_order_id);
    }

    #[rstest]
    fn test_lookup_order_metadata_returns_none_when_unknown() {
        let caches = test_caches();
        let ws_order = test_ws_order("UNKNOWN-OID", dec!(0), 0);
        assert!(lookup_order_metadata(&ws_order, &caches).is_none());
    }

    #[rstest]
    #[case(true, LiquiditySide::Taker)]
    #[case(false, LiquiditySide::Maker)]
    fn test_create_order_filled_maps_liquidity_side(
        #[case] agg: bool,
        #[case] expected: LiquiditySide,
    ) {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-FILL");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        let venue_order_id = VenueOrderId::new("OID-FILL");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(venue_order_id, client_order_id);

        let order = test_ws_order(venue_order_id.as_str(), dec!(50500.00), 100);
        let execution = test_execution("TID-1", dec!(50500.00), 25, agg);

        let event = create_order_filled(
            &order, &execution, 1609459200, 0, &caches, account_id, clock,
        )
        .expect("should produce OrderFilled");

        assert_eq!(event.venue_order_id, venue_order_id);
        assert_eq!(event.client_order_id, client_order_id);
        assert_eq!(event.trade_id, TradeId::new("TID-1"));
        assert_eq!(event.last_qty, Quantity::new(25.0, 0));
        assert_eq!(event.last_px, Price::from("50500.00"));
        assert_eq!(event.liquidity_side, expected);
    }

    #[rstest]
    fn test_create_order_canceled_populates_identifiers() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-CXL");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        let venue_order_id = VenueOrderId::new("OID-CXL");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(venue_order_id, client_order_id);

        let order = test_ws_order(venue_order_id.as_str(), dec!(100.00), 10);
        let event = create_order_canceled(&order, 1609459200, 0, &caches, account_id, clock)
            .expect("should produce OrderCanceled");

        assert_eq!(event.venue_order_id, Some(venue_order_id));
        assert_eq!(event.client_order_id, client_order_id);
        assert_eq!(event.account_id, Some(account_id));
        assert_eq!(event.instrument_id, instrument_id);
    }

    #[rstest]
    fn test_create_order_expired_populates_identifiers() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-EXP");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        let venue_order_id = VenueOrderId::new("OID-EXP");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(venue_order_id, client_order_id);

        let order = test_ws_order(venue_order_id.as_str(), dec!(100.00), 10);
        let event = create_order_expired(&order, 1609459200, 0, &caches, account_id, clock)
            .expect("should produce OrderExpired");

        assert_eq!(event.venue_order_id, Some(venue_order_id));
        assert_eq!(event.client_order_id, client_order_id);
    }

    #[rstest]
    #[case(AxTimeInForce::Ioc, true)]
    #[case(AxTimeInForce::Fok, true)]
    #[case(AxTimeInForce::Day, false)]
    #[case(AxTimeInForce::Gtc, false)]
    fn test_dispatch_expired_maps_ioc_fok_to_canceled(
        #[case] tif: AxTimeInForce,
        #[case] expect_canceled: bool,
    ) {
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let (tx, mut rx) = tokio::sync::mpsc::unbounded_channel();
        let mut emitter = ExecutionEventEmitter::new(
            clock,
            TraderId::from("TESTER-001"),
            account_id,
            AccountType::Margin,
            None,
        );
        emitter.set_sender(tx);

        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-EXP");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(VenueOrderId::new("OID-EXP"), client_order_id);

        let mut order = test_ws_order("OID-EXP", dec!(100.00), 10);
        order.tif = tif;
        let event = AxWsOrderEvent::Expired(AxWsOrderExpired {
            ts: 1609459200,
            tn: 0,
            eid: "E-EXP".to_string(),
            o: order,
        });

        let instruments: AtomicMap<Ustr, InstrumentAny> = AtomicMap::new();
        dispatch_order_event(event, &emitter, &caches, account_id, &instruments, clock);

        match rx.try_recv().expect("an order event should be emitted") {
            ExecutionEvent::Order(OrderEventAny::Canceled(_)) => assert!(expect_canceled),
            ExecutionEvent::Order(OrderEventAny::Expired(_)) => assert!(!expect_canceled),
            other => panic!("unexpected event: {other:?}"),
        }
    }

    #[rstest]
    fn test_create_order_rejected_sets_due_post_only_when_reason_matches() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-REJ");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(VenueOrderId::new("OID-REJ"), client_order_id);

        let order = test_ws_order("OID-REJ", dec!(100.00), 10);
        // Use the literal venue reason text so this guards the AX_POST_ONLY_REJECT constant
        let reason = "post-only order would cross the book";
        let event =
            create_order_rejected(&order, reason, 1609459200, 0, &caches, account_id, clock)
                .expect("should produce OrderRejected");

        assert!(event.due_post_only, "post-only reason should set flag");
        assert_eq!(event.reason, Ustr::from(reason));
    }

    #[rstest]
    fn test_create_order_rejected_clears_due_post_only_for_other_reasons() {
        let caches = test_caches();
        let clock = get_atomic_clock_realtime();
        let account_id = AccountId::from("AX-001");
        let client_order_id = ClientOrderId::from("O-REJ-2");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(VenueOrderId::new("OID-REJ-2"), client_order_id);

        let order = test_ws_order("OID-REJ-2", dec!(100.00), 10);
        let event = create_order_rejected(
            &order,
            "INSUFFICIENT_MARGIN",
            1609459200,
            0,
            &caches,
            account_id,
            clock,
        )
        .expect("should produce OrderRejected");

        assert!(!event.due_post_only);
        assert_eq!(event.reason, Ustr::from("INSUFFICIENT_MARGIN"));
    }

    #[rstest]
    fn test_cleanup_terminal_order_tracking_removes_all_caches() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-CLEAN");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        let venue_order_id = VenueOrderId::new("OID-CLEAN");
        let stale_venue_order_id = VenueOrderId::new("OID-CLEAN-OLD");
        let cid_value = 123u64;

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .venue_to_client_id
            .insert(venue_order_id, client_order_id);
        caches
            .venue_to_client_id
            .insert(stale_venue_order_id, client_order_id);
        caches
            .cid_to_client_order_id
            .insert(cid_value, client_order_id);

        let mut order = test_ws_order(venue_order_id.as_str(), dec!(100.00), 10);
        order.cid = Some(cid_value);

        cleanup_terminal_order_tracking(&order, &caches);

        assert!(caches.orders_metadata.is_empty());
        assert!(caches.venue_to_client_id.is_empty());
        assert!(caches.cid_to_client_order_id.is_empty());
    }

    #[rstest]
    fn test_cleanup_terminal_order_tracking_via_cid_when_venue_missing() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-CLEAN-CID");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        let cid_value = 321u64;

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, instrument_id),
        );
        caches
            .cid_to_client_order_id
            .insert(cid_value, client_order_id);

        // Venue id missing from cache
        let mut order = test_ws_order("OID-UNKNOWN", dec!(100.00), 10);
        order.cid = Some(cid_value);

        cleanup_terminal_order_tracking(&order, &caches);

        assert!(caches.orders_metadata.is_empty());
        assert!(caches.cid_to_client_order_id.is_empty());
    }

    #[rstest]
    fn test_cleanup_terminal_order_tracking_noop_when_unknown() {
        let caches = test_caches();
        let other = ClientOrderId::from("OTHER");
        let instrument_id = InstrumentId::from("BTC-PERP.AX");
        caches
            .orders_metadata
            .insert(other, test_metadata(other, instrument_id));

        let order = test_ws_order("OID-NOT-TRACKED", dec!(100.00), 10);
        cleanup_terminal_order_tracking(&order, &caches);

        // Unrelated metadata still present
        assert_eq!(caches.orders_metadata.len(), 1);
    }

    #[rstest]
    fn test_cleanup_closed_order_status_report_removes_all_caches() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-RECON-FILL");
        let venue_order_id = VenueOrderId::new("OID-RECON-FILL");
        let stale_venue_order_id = VenueOrderId::new("OID-RECON-FILL-OLD");
        let cid_value = client_order_id_to_cid(&client_order_id);

        seed_terminal_tracking(
            &caches,
            client_order_id,
            venue_order_id,
            stale_venue_order_id,
            cid_value,
        );

        let report = test_status_report(Some(client_order_id), venue_order_id, OrderStatus::Filled);
        cleanup_closed_order_status_report(&report, &caches);

        assert!(caches.orders_metadata.is_empty());
        assert!(caches.venue_to_client_id.is_empty());
        assert!(caches.cid_to_client_order_id.is_empty());
    }

    #[rstest]
    fn test_cleanup_closed_order_status_report_via_venue_when_client_id_absent() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-RECON-CANCEL");
        let venue_order_id = VenueOrderId::new("OID-RECON-CANCEL");
        let stale_venue_order_id = VenueOrderId::new("OID-RECON-CANCEL-OLD");
        let cid_value = 654u64;

        seed_terminal_tracking(
            &caches,
            client_order_id,
            venue_order_id,
            stale_venue_order_id,
            cid_value,
        );

        let report = test_status_report(None, venue_order_id, OrderStatus::Canceled);
        cleanup_closed_order_status_report(&report, &caches);

        assert!(caches.orders_metadata.is_empty());
        assert!(caches.venue_to_client_id.is_empty());
        assert!(caches.cid_to_client_order_id.is_empty());
    }

    #[rstest]
    fn test_cleanup_closed_order_status_report_prefers_venue_identity() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-EXT-RECON");
        let venue_order_id = VenueOrderId::new("OID-EXT-RECON");
        let stale_venue_order_id = VenueOrderId::new("OID-EXT-RECON-OLD");

        caches.orders_metadata.insert(
            client_order_id,
            test_metadata(client_order_id, InstrumentId::from("BTC-PERP.AX")),
        );
        caches
            .venue_to_client_id
            .insert(venue_order_id, client_order_id);
        caches
            .venue_to_client_id
            .insert(stale_venue_order_id, client_order_id);

        let report = test_status_report(
            Some(cid_to_client_order_id(99)),
            venue_order_id,
            OrderStatus::Filled,
        );
        cleanup_closed_order_status_report(&report, &caches);

        assert!(caches.orders_metadata.is_empty());
        assert!(caches.venue_to_client_id.is_empty());
        assert!(caches.cid_to_client_order_id.is_empty());
    }

    #[rstest]
    fn test_cleanup_open_order_status_report_retains_caches() {
        let caches = test_caches();
        let client_order_id = ClientOrderId::from("O-RECON-OPEN");
        let venue_order_id = VenueOrderId::new("OID-RECON-OPEN");
        let stale_venue_order_id = VenueOrderId::new("OID-RECON-OPEN-OLD");
        let cid_value = client_order_id_to_cid(&client_order_id);

        seed_terminal_tracking(
            &caches,
            client_order_id,
            venue_order_id,
            stale_venue_order_id,
            cid_value,
        );

        let report =
            test_status_report(Some(client_order_id), venue_order_id, OrderStatus::Accepted);
        cleanup_closed_order_status_report(&report, &caches);

        assert!(caches.orders_metadata.contains_key(&client_order_id));
        assert_eq!(
            *caches.venue_to_client_id.get(&venue_order_id).unwrap(),
            client_order_id
        );
        assert_eq!(
            *caches.cid_to_client_order_id.get(&cid_value).unwrap(),
            client_order_id
        );
    }

    #[rstest]
    fn test_cleanup_closed_order_status_reports_only_cleans_terminal() {
        let caches = test_caches();
        let filled_client_order_id = ClientOrderId::from("O-RECON-BATCH-FILL");
        let filled_venue_order_id = VenueOrderId::new("OID-RECON-BATCH-FILL");
        let filled_stale_venue_order_id = VenueOrderId::new("OID-RECON-BATCH-FILL-OLD");
        let filled_cid = client_order_id_to_cid(&filled_client_order_id);
        let open_client_order_id = ClientOrderId::from("O-RECON-BATCH-OPEN");
        let open_venue_order_id = VenueOrderId::new("OID-RECON-BATCH-OPEN");
        let open_stale_venue_order_id = VenueOrderId::new("OID-RECON-BATCH-OPEN-OLD");
        let open_cid = client_order_id_to_cid(&open_client_order_id);

        seed_terminal_tracking(
            &caches,
            filled_client_order_id,
            filled_venue_order_id,
            filled_stale_venue_order_id,
            filled_cid,
        );
        seed_terminal_tracking(
            &caches,
            open_client_order_id,
            open_venue_order_id,
            open_stale_venue_order_id,
            open_cid,
        );

        let reports = vec![
            test_status_report(
                Some(filled_client_order_id),
                filled_venue_order_id,
                OrderStatus::Filled,
            ),
            test_status_report(
                Some(open_client_order_id),
                open_venue_order_id,
                OrderStatus::Accepted,
            ),
        ];

        for report in &reports {
            cleanup_closed_order_status_report(report, &caches);
        }

        assert!(!caches.orders_metadata.contains_key(&filled_client_order_id));
        assert!(
            !caches
                .venue_to_client_id
                .contains_key(&filled_venue_order_id)
        );
        assert!(!caches.cid_to_client_order_id.contains_key(&filled_cid));
        assert!(caches.orders_metadata.contains_key(&open_client_order_id));
        assert_eq!(
            *caches.venue_to_client_id.get(&open_venue_order_id).unwrap(),
            open_client_order_id
        );
        assert_eq!(
            *caches.cid_to_client_order_id.get(&open_cid).unwrap(),
            open_client_order_id
        );
    }

    #[rstest]
    #[tokio::test]
    async fn test_generate_order_status_reports_cleans_terminal_tracking() {
        let filled_client_order_id = ClientOrderId::from("O-RECON-HTTP-FILL");
        let filled_venue_order_id = VenueOrderId::new("OID-RECON-HTTP-FILL");
        let filled_stale_venue_order_id = VenueOrderId::new("OID-RECON-HTTP-FILL-OLD");
        let filled_cid = client_order_id_to_cid(&filled_client_order_id);
        let open_client_order_id = ClientOrderId::from("O-RECON-HTTP-OPEN");
        let open_venue_order_id = VenueOrderId::new("OID-RECON-HTTP-OPEN");
        let open_stale_venue_order_id = VenueOrderId::new("OID-RECON-HTTP-OPEN-OLD");
        let open_cid = client_order_id_to_cid(&open_client_order_id);

        let addr = start_orders_report_server(serde_json::json!({
            "orders": [
                {
                    "ts": 1_704_067_200,
                    "tn": 500_000_000,
                    "oid": filled_venue_order_id.as_str(),
                    "u": "u",
                    "s": "BTC-PERP",
                    "p": "100.00",
                    "q": 10,
                    "xq": 10,
                    "rq": 0,
                    "o": "FILLED",
                    "d": "B",
                    "tif": "GTC",
                    "cid": filled_cid,
                    "po": false
                },
                {
                    "ts": 1_704_067_201,
                    "tn": 500_000_000,
                    "oid": open_venue_order_id.as_str(),
                    "u": "u",
                    "s": "BTC-PERP",
                    "p": "100.00",
                    "q": 10,
                    "xq": 0,
                    "rq": 10,
                    "o": "ACCEPTED",
                    "d": "B",
                    "tif": "GTC",
                    "cid": open_cid,
                    "po": false
                }
            ]
        }))
        .await;

        let cache = Rc::new(RefCell::new(Cache::default()));

        let core = ExecutionClientCore::new(
            TraderId::from("TESTER-001"),
            *AX_CLIENT_ID,
            *AX_VENUE,
            OmsType::Netting,
            AccountId::from("AX-001"),
            AccountType::Margin,
            None,
            cache,
        );

        let config = AxExecutionClientConfig {
            api_key: Some("test_api_key".into()),
            api_secret: Some("test_api_secret".into()),
            environment: AxEnvironment::Sandbox,
            base_url_http: Some(format!("http://{addr}")),
            base_url_orders: Some(format!("http://{addr}")),
            base_url_ws_private: Some(format!("ws://{addr}/orders/ws")),
            http_timeout_secs: 5,
            max_retries: 1,
            retry_delay_initial_ms: 10,
            retry_delay_max_ms: 10,
            ..Default::default()
        };

        let client = AxExecutionClient::new(core, config).expect("create exec client");
        client.http_client.set_session_token("test-token".into());
        client
            .http_client
            .cache_instrument(test_perp_instrument("BTC-PERP"));

        seed_terminal_tracking(
            client.ws_orders.caches(),
            filled_client_order_id,
            filled_venue_order_id,
            filled_stale_venue_order_id,
            filled_cid,
        );
        seed_terminal_tracking(
            client.ws_orders.caches(),
            open_client_order_id,
            open_venue_order_id,
            open_stale_venue_order_id,
            open_cid,
        );

        let cmd = GenerateOrderStatusReports::new(
            UUID4::new(),
            UnixNanos::default(),
            false,
            None,
            None,
            None,
            None,
            None,
        );
        let reports = client
            .generate_order_status_reports(&cmd)
            .await
            .expect("generate_order_status_reports");

        assert_eq!(reports.len(), 2);
        let filled = reports
            .iter()
            .find(|report| report.venue_order_id == filled_venue_order_id)
            .expect("filled report");
        let open = reports
            .iter()
            .find(|report| report.venue_order_id == open_venue_order_id)
            .expect("open report");
        assert_eq!(filled.order_status, OrderStatus::Filled);
        assert_eq!(filled.client_order_id, Some(filled_client_order_id));
        assert_eq!(open.order_status, OrderStatus::Accepted);
        assert_eq!(open.client_order_id, Some(open_client_order_id));

        let caches = client.ws_orders.caches();
        assert!(!caches.orders_metadata.contains_key(&filled_client_order_id));
        assert!(
            !caches
                .venue_to_client_id
                .contains_key(&filled_venue_order_id)
        );
        assert!(!caches.cid_to_client_order_id.contains_key(&filled_cid));
        assert!(caches.orders_metadata.contains_key(&open_client_order_id));
        assert_eq!(
            *caches.venue_to_client_id.get(&open_venue_order_id).unwrap(),
            open_client_order_id
        );
        assert_eq!(
            *caches.cid_to_client_order_id.get(&open_cid).unwrap(),
            open_client_order_id
        );
    }

    #[rstest]
    fn test_cancel_on_disconnect_url_no_existing_query() {
        let mut url = "wss://example.com/orders/ws".to_string();
        let separator = if url.contains('?') { "&" } else { "?" };
        url.push_str(&format!("{separator}cancel_on_disconnect=true"));
        assert_eq!(url, "wss://example.com/orders/ws?cancel_on_disconnect=true");
    }

    #[rstest]
    fn test_cancel_on_disconnect_url_with_existing_query() {
        let mut url = "wss://example.com/orders/ws?token=abc".to_string();
        let separator = if url.contains('?') { "&" } else { "?" };
        url.push_str(&format!("{separator}cancel_on_disconnect=true"));
        assert_eq!(
            url,
            "wss://example.com/orders/ws?token=abc&cancel_on_disconnect=true"
        );
    }

    fn limit_order_for_validation(quantity: Quantity) -> OrderAny {
        OrderTestBuilder::new(OrderType::Limit)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(quantity)
            .price(Price::from("1.10"))
            .build()
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_accepts_supported_limit_order() {
        let order = limit_order_for_validation(Quantity::from("10"));

        assert!(validate_order_for_ax_submit(&order).is_ok());
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_unsupported_order_type() {
        let order = OrderTestBuilder::new(OrderType::StopMarket)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(Quantity::from("10"))
            .trigger_price(Price::from("1.10"))
            .build();

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("Unsupported order type"));
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_gtd_time_in_force() {
        let order = OrderTestBuilder::new(OrderType::Limit)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(Quantity::from("10"))
            .price(Price::from("1.10"))
            .time_in_force(TimeInForce::Gtd)
            .expire_time(UnixNanos::from(2_000_000_000_000_000_000u64))
            .build();

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("Unsupported time in force"));
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_stop_limit_order() {
        let order = OrderTestBuilder::new(OrderType::StopLimit)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(Quantity::from("10"))
            .price(Price::from("1.11"))
            .trigger_price(Price::from("1.10"))
            .build();

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("Unsupported order type"));
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_fok_time_in_force() {
        let order = OrderTestBuilder::new(OrderType::Limit)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(Quantity::from("10"))
            .price(Price::from("1.10"))
            .time_in_force(TimeInForce::Fok)
            .build();

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("Unsupported time in force"));
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_fractional_quantity() {
        let order = limit_order_for_validation(Quantity::from("10.5"));

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("whole contract"));
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_quote_quantity() {
        let order = OrderTestBuilder::new(OrderType::Market)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(Quantity::from("10"))
            .time_in_force(TimeInForce::Ioc)
            .quote_quantity(true)
            .build();

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("quote_quantity"));
    }

    #[rstest]
    fn test_validate_order_for_ax_submit_denies_display_quantity() {
        let order = OrderTestBuilder::new(OrderType::Limit)
            .instrument_id(InstrumentId::from("EURUSD-PERP.AX"))
            .side(OrderSide::Buy)
            .quantity(Quantity::from("10"))
            .price(Price::from("1.10"))
            .display_qty(Quantity::from("5"))
            .build();

        let err = validate_order_for_ax_submit(&order).unwrap_err();

        assert!(err.to_string().contains("display_qty"));
    }

    #[rstest]
    #[case(AxHttpError::MissingCredentials, true)]
    #[case(AxHttpError::MissingSessionToken, true)]
    #[case(AxHttpError::ValidationError("bad param".to_string()), true)]
    #[case(AxHttpError::BuildError(AxBuildError::MissingOrderId), true)]
    #[case(AxHttpError::ApiError { message: "invalid modification".to_string() }, false)]
    #[case(AxHttpError::JsonError("parse failure".to_string()), false)]
    #[case(AxHttpError::Canceled("shutdown".to_string()), false)]
    #[case(AxHttpError::NetworkError("timeout".to_string()), false)]
    #[case(AxHttpError::UnexpectedStatus { status: 400, body: "invalid".to_string() }, false)]
    #[case(AxHttpError::UnexpectedStatus { status: 503, body: String::new() }, false)]
    fn test_classify_ax_http_failure(#[case] error: AxHttpError, #[case] expect_not_sent: bool) {
        // Asserting the exact variant also pins that AX never classifies a venue rejection
        let expected = if expect_not_sent {
            CommandFailure::NotSent(error.to_string())
        } else {
            CommandFailure::Ambiguous(error.to_string())
        };

        assert_eq!(classify_ax_http_failure(&error), expected);
    }

    #[rstest]
    #[case(
        AxOrdersWsClientError::ClientError("missing venue_order_id".to_string()),
        Some("missing venue_order_id")
    )]
    #[case(AxOrdersWsClientError::ChannelError("handler closed".to_string()), None)]
    #[case(AxOrdersWsClientError::Transport("connection reset".to_string()), None)]
    #[case(AxOrdersWsClientError::AuthenticationError("token expired".to_string()), None)]
    fn test_classify_ax_ws_failure(
        #[case] error: AxOrdersWsClientError,
        #[case] not_sent_reason: Option<&str>,
    ) {
        // Asserting the exact variant also pins that AX never classifies a venue rejection
        let expected = match not_sent_reason {
            Some(reason) => CommandFailure::NotSent(reason.to_string()),
            None => CommandFailure::Ambiguous(error.to_string()),
        };

        assert_eq!(classify_ax_ws_failure(&error), expected);
    }
}