nautilus_kraken/execution/

spot.rs

// -------------------------------------------------------------------------------------------------
//  Copyright (C) 2015-2026 Nautech Systems Pty Ltd. All rights reserved.
//  https://nautechsystems.io
//
//  Licensed under the GNU Lesser General Public License Version 3.0 (the "License");
//  You may not use this file except in compliance with the License.
//  You may obtain a copy of the License at https://www.gnu.org/licenses/lgpl-3.0.en.html
//
//  Unless required by applicable law or agreed to in writing, software
//  distributed under the License is distributed on an "AS IS" BASIS,
//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//  See the License for the specific language governing permissions and
//  limitations under the License.
// -------------------------------------------------------------------------------------------------

//! Kraken Spot execution client implementation.

use std::{
    collections::HashSet,
    future::Future,
    sync::{Arc, Mutex},
    time::{Duration, Instant},
};

use anyhow::Context;
use async_trait::async_trait;
use chrono::{DateTime, Utc};
use futures_util::StreamExt;
use nautilus_common::{
    cache::InstrumentLookupError,
    clients::ExecutionClient,
    live::{get_runtime, runner::get_exec_event_sender},
    messages::execution::{
        BatchCancelOrders, CancelAllOrders, CancelOrder, GenerateFillReports,
        GenerateOrderStatusReport, GenerateOrderStatusReports, GeneratePositionStatusReports,
        ModifyOrder, QueryAccount, QueryOrder, SubmitOrder, SubmitOrderList,
    },
};
use nautilus_core::{
    AtomicMap, MUTEX_POISONED, Params, UnixNanos,
    time::{AtomicTime, get_atomic_clock_realtime},
};
use nautilus_live::{ExecutionClientCore, ExecutionEventEmitter};
use nautilus_model::{
    accounts::AccountAny,
    enums::{
        AccountType, OmsType, OrderSide, OrderType, PositionSideSpecified, TimeInForce,
        TrailingOffsetType, TriggerType,
    },
    events::OrderEventAny,
    identifiers::{
        AccountId, ClientId, ClientOrderId, InstrumentId, StrategyId, Venue, VenueOrderId,
    },
    instruments::{Instrument, InstrumentAny},
    orders::{Order, OrderAny},
    reports::{ExecutionMassStatus, FillReport, OrderStatusReport, PositionStatusReport},
    types::{AccountBalance, MarginBalance, Price, Quantity},
};
use rust_decimal::Decimal;
use tokio::task::JoinHandle;
use tokio_util::sync::CancellationToken;
use ustr::Ustr;

use super::{
    CancelCommandFailure, classify_cancel_http_failure, classify_spot_single_cancel_http_failure,
};
use crate::{
    common::{
        consts::{KRAKEN_SPOT_POST_ONLY_ERROR, KRAKEN_VENUE},
        enums::{
            KrakenOrderSide, KrakenOrderType, KrakenProductType, KrakenSpotTrigger,
            KrakenTimeInForce, product_type_from_symbol,
        },
        order_params::{
            build_add_order_params, build_amend_order_params, build_cancel_order_params,
            compute_ws_time_in_force, format_expire_time,
        },
        parse::truncate_cl_ord_id,
    },
    config::KrakenExecClientConfig,
    http::{
        KrakenSpotCancelOrderBatchParams, KrakenSpotCancelOrderParamsBuilder, KrakenSpotHttpClient,
        spot::client::KRAKEN_SPOT_DEFAULT_RATE_LIMIT_PER_SECOND,
    },
    websocket::{
        dispatch::{
            self, OrderIdentity, WsDispatchState,
            spot_orders::{OrderRequestState, PendingOperation, PendingRequest},
        },
        spot_v2::{
            client::KrakenSpotWebSocketClient,
            messages::{
                KrakenSpotWsMessage, KrakenWsBatchAddOrder, KrakenWsBatchAddParams,
                KrakenWsTriggerParams,
            },
        },
    },
};

/// Kraken Spot execution client.
///
/// Provides order management and account operations for Kraken Spot markets.
#[allow(dead_code)]
#[derive(Debug)]
pub struct KrakenSpotExecutionClient {
    core: ExecutionClientCore,
    clock: &'static AtomicTime,
    config: KrakenExecClientConfig,
    emitter: ExecutionEventEmitter,
    http: KrakenSpotHttpClient,
    ws: KrakenSpotWebSocketClient,
    cancellation_token: CancellationToken,
    ws_stream_handle: Option<JoinHandle<()>>,
    pending_tasks: Mutex<Vec<JoinHandle<()>>>,
    instruments: Arc<AtomicMap<InstrumentId, InstrumentAny>>,
    order_qty_cache: Arc<AtomicMap<String, f64>>,
    truncated_id_map: Arc<AtomicMap<String, ClientOrderId>>,
    ws_dispatch_state: Arc<WsDispatchState>,
    order_request_state: Arc<OrderRequestState>,
    order_event_rx: Mutex<Option<tokio::sync::mpsc::UnboundedReceiver<OrderEventAny>>>,
}

impl KrakenSpotExecutionClient {
    /// Creates a new [`KrakenSpotExecutionClient`].
    pub fn new(core: ExecutionClientCore, config: KrakenExecClientConfig) -> anyhow::Result<Self> {
        let clock = get_atomic_clock_realtime();
        let emitter = ExecutionEventEmitter::new(
            clock,
            core.trader_id,
            core.account_id,
            config.spot_account_type,
            None,
        );

        let cancellation_token = CancellationToken::new();

        let http = KrakenSpotHttpClient::with_credentials(
            config.api_key.clone(),
            config.api_secret.clone(),
            config.environment,
            config.base_url.clone(),
            config.timeout_secs,
            None,
            None,
            None,
            config.proxy_url.clone(),
            config
                .max_requests_per_second
                .unwrap_or(KRAKEN_SPOT_DEFAULT_RATE_LIMIT_PER_SECOND),
        )?;

        let data_config = crate::config::KrakenDataClientConfig {
            api_key: Some(config.api_key.clone()),
            api_secret: Some(config.api_secret.clone()),
            product_type: config.product_type,
            environment: config.environment,
            base_url: config.base_url.clone(),
            ws_public_url: None,
            ws_private_url: Some(config.ws_url()),
            ws_l3_url: None,
            validate_l3_checksum: true,
            proxy_url: config.proxy_url.clone(),
            timeout_secs: config.timeout_secs,
            heartbeat_interval_secs: config.heartbeat_interval_secs,
            // The authenticated order-routing WS keeps its prior behavior (no
            // idle timeout); issue #4255 concerns the public spot data WS.
            ws_idle_timeout_ms: 0,
            max_requests_per_second: config.max_requests_per_second,
            transport_backend: config.transport_backend,
        };
        let ws = KrakenSpotWebSocketClient::new(
            data_config,
            cancellation_token.clone(),
            config.proxy_url.clone(),
        );

        let ws_dispatch_state = Arc::new(WsDispatchState::new());
        // Connect() swaps in a live cmd_tx; capture the shared handle so the
        // dispatcher reads the current sender, not the dropped placeholder.
        let cmd_tx_handle = ws.handler_command_handle();
        let (order_event_tx, order_event_rx) = tokio::sync::mpsc::unbounded_channel();
        let order_request_state = Arc::new(OrderRequestState::new(
            cmd_tx_handle,
            order_event_tx,
            Arc::clone(&ws_dispatch_state),
            ws.req_id_counter(),
            Duration::from_secs(config.ws_request_timeout_secs),
            core.trader_id,
            core.account_id,
            ws.auth_token_handle(),
            cancellation_token.clone(),
            clock,
        ));

        Ok(Self {
            core,
            clock,
            config,
            emitter,
            http,
            ws,
            cancellation_token,
            ws_stream_handle: None,
            pending_tasks: Mutex::new(Vec::new()),
            instruments: Arc::new(AtomicMap::new()),
            order_qty_cache: Arc::new(AtomicMap::new()),
            truncated_id_map: Arc::new(AtomicMap::new()),
            ws_dispatch_state,
            order_request_state,
            order_event_rx: Mutex::new(Some(order_event_rx)),
        })
    }

    fn register_order_identity(&self, order: &OrderAny) {
        // Quote-quantity orders submit a quote amount (e.g. 100 USD), but the
        // venue reports fills in base units (e.g. 0.001 BTC). Registering the
        // raw `order.quantity()` would make the cumulative-fill comparison in
        // the fill-side dispatch mismatch base against quote, leaving the
        // order "open" forever. These orders instead flow through the
        // untracked path and the engine reconciles them from status reports.
        if order.is_quote_quantity() {
            return;
        }
        self.ws_dispatch_state.register_identity(
            order.client_order_id(),
            OrderIdentity {
                strategy_id: order.strategy_id(),
                instrument_id: order.instrument_id(),
                order_side: order.order_side(),
                order_type: order.order_type(),
                quantity: order.quantity(),
            },
        );
    }

    /// Returns a reference to the clock.
    #[must_use]
    pub fn clock(&self) -> &'static AtomicTime {
        self.clock
    }

    /// Returns a reference to the event emitter.
    #[must_use]
    pub fn emitter(&self) -> &ExecutionEventEmitter {
        &self.emitter
    }

    fn spawn_task<F>(&self, description: &'static str, fut: F)
    where
        F: Future<Output = anyhow::Result<()>> + Send + 'static,
    {
        let runtime = get_runtime();
        let handle = runtime.spawn(async move {
            if let Err(e) = fut.await {
                log::warn!("{description} failed: {e:?}");
            }
        });

        let mut tasks = self.pending_tasks.lock().expect(MUTEX_POISONED);
        tasks.retain(|handle| !handle.is_finished());
        tasks.push(handle);
    }

    fn submit_single_order(
        &self,
        command: &SubmitOrder,
        order: &OrderAny,
        task_name: &'static str,
        leverage: Option<u16>,
    ) {
        if order.is_closed() {
            log::warn!(
                "Cannot submit closed order: client_order_id={}",
                order.client_order_id()
            );
            return;
        }

        let order_type = order.order_type();
        let time_in_force = order.time_in_force();

        if time_in_force == TimeInForce::Fok && order_type != OrderType::Limit {
            self.emitter.emit_order_denied(
                order,
                "FOK time in force only supported for LIMIT orders on Kraken Spot",
            );
            return;
        }

        if matches!(
            order_type,
            OrderType::TrailingStopMarket | OrderType::TrailingStopLimit
        ) && let Some(offset_type) = order.trailing_offset_type()
            && offset_type != TrailingOffsetType::Price
        {
            self.emitter.emit_order_denied(
                order,
                &format!(
                    "Kraken Spot only supports Price trailing offset type: received {offset_type:?}"
                ),
            );
            return;
        }

        if order.is_reduce_only() && self.config.spot_account_type == AccountType::Cash {
            self.emitter
                .emit_order_denied(order, "reduce_only requires spot_account_type=Margin");
            return;
        }

        let client_order_id = order.client_order_id();

        log::debug!("OrderSubmitted: client_order_id={client_order_id}");
        self.register_order_identity(order);
        self.emitter.emit_order_submitted(order);

        let kraken_cl_ord_id = truncate_cl_ord_id(&client_order_id);

        if !order.is_quote_quantity() {
            self.order_qty_cache
                .insert(kraken_cl_ord_id.clone(), order.quantity().as_f64());
        }

        if kraken_cl_ord_id != client_order_id.as_str() {
            self.truncated_id_map
                .insert(kraken_cl_ord_id, client_order_id);
        }

        // Quote-quantity orders submit a quote-currency amount but the venue echoes
        // fills in base units. The WS dispatch identity is intentionally not
        // registered for these (see register_order_identity), so a WS round-trip
        // would never emit OrderAccepted to the strategy. Plus order.quantity()
        // for quote-qty is a quote amount that would be wrongly sent as `order_qty`
        // (base units) on the WS path. Force REST.
        let use_ws_trade = resolve_use_ws_trade(command.params.as_ref(), self.config.use_ws_trade);
        if use_ws_trade && self.ws.is_active() && !order.is_quote_quantity() {
            match self.submit_via_ws(command, order, leverage) {
                Ok(()) => return,
                Err(e) => log::warn!("Kraken WS submit_order fallback to REST: {e}"),
            }
        }

        self.submit_via_rest(order, task_name, leverage);
    }

    fn submit_via_rest(&self, order: &OrderAny, task_name: &'static str, leverage: Option<u16>) {
        let account_id = self.core.account_id;
        let client_order_id = order.client_order_id();
        let strategy_id = order.strategy_id();
        let instrument_id = order.instrument_id();
        let order_side = order.order_side();
        let order_type = order.order_type();
        let quantity = order.quantity();
        let time_in_force = order.time_in_force();
        let expire_time = order.expire_time();
        let price = order.price();
        let trigger_price = order.trigger_price();
        let trigger_type = order.trigger_type();
        let trailing_offset = order.trailing_offset();
        let limit_offset = order.limit_offset();
        let is_reduce_only = order.is_reduce_only();
        let is_post_only = order.is_post_only();
        let is_quote_quantity = order.is_quote_quantity();
        let display_qty = order.display_qty();

        let http = self.http.clone();
        let emitter = self.emitter.clone();
        let clock = self.clock;
        let dispatch_state = self.ws_dispatch_state.clone();
        let spot_account_type = self.config.spot_account_type;

        self.spawn_task(task_name, async move {
            let result = http
                .submit_order(
                    account_id,
                    instrument_id,
                    client_order_id,
                    order_side,
                    order_type,
                    quantity,
                    time_in_force,
                    expire_time,
                    price,
                    trigger_price,
                    trigger_type,
                    trailing_offset,
                    limit_offset,
                    is_reduce_only,
                    is_post_only,
                    is_quote_quantity,
                    display_qty,
                    leverage,
                    spot_account_type,
                )
                .await;

            if let Err(e) = result {
                let ts_event = clock.get_time_ns();
                let error_msg = format!("{task_name} error: {e}");
                let due_post_only = error_msg.contains("POST_ONLY_REJECTED")
                    || error_msg.contains(KRAKEN_SPOT_POST_ONLY_ERROR);
                dispatch_state.cleanup_terminal(&client_order_id);
                emitter.emit_order_rejected_event(
                    strategy_id,
                    instrument_id,
                    client_order_id,
                    &error_msg,
                    ts_event,
                    due_post_only,
                );
                return Ok(());
            }

            Ok(())
        });
    }

    fn submit_via_ws(
        &self,
        command: &SubmitOrder,
        order: &OrderAny,
        leverage: Option<u16>,
    ) -> anyhow::Result<()> {
        let token = self
            .ws
            .auth_token_blocking()
            .ok_or_else(|| anyhow::anyhow!("missing WS auth token"))?;

        let params = build_add_order_params(command, order, token, leverage)?;
        let identity = PendingRequest {
            operation: PendingOperation::Submit,
            client_order_ids: vec![command.client_order_id],
            venue_order_ids: vec![None],
            ts_sent_ns: 0,
            new_quantity: None,
            new_price: None,
            new_trigger_price: None,
        };
        self.order_request_state
            .submit(params, identity, self.clock.get_time_ns().as_u64())?;
        Ok(())
    }

    fn cancel_single_order(&self, cmd: &CancelOrder) {
        let use_ws_trade = resolve_use_ws_trade(cmd.params.as_ref(), self.config.use_ws_trade);
        if use_ws_trade && self.ws.is_active() {
            match self.cancel_via_ws(cmd) {
                Ok(()) => return,
                Err(e) => log::warn!("Kraken WS cancel_order fallback to REST: {e}"),
            }
        }

        self.cancel_via_rest(cmd);
    }

    fn cancel_via_rest(&self, cmd: &CancelOrder) {
        let account_id = self.core.account_id;
        let client_order_id = cmd.client_order_id;
        let venue_order_id = cmd.venue_order_id;
        let strategy_id = cmd.strategy_id;
        let instrument_id = cmd.instrument_id;

        log::debug!(
            "Canceling order: venue_order_id={venue_order_id:?}, client_order_id={client_order_id}"
        );

        let http = self.http.clone();
        let emitter = self.emitter.clone();
        let clock = self.clock;

        self.spawn_task("cancel_order", async move {
            if let Err(failure) = cancel_order_for_spot(
                &http,
                account_id,
                instrument_id,
                Some(client_order_id),
                venue_order_id,
            )
            .await
            {
                handle_cancel_failure(
                    &emitter,
                    clock,
                    strategy_id,
                    instrument_id,
                    client_order_id,
                    venue_order_id,
                    failure,
                );
            }
            Ok(())
        });
    }

    fn cancel_via_ws(&self, cmd: &CancelOrder) -> anyhow::Result<()> {
        let token = self
            .ws
            .auth_token_blocking()
            .ok_or_else(|| anyhow::anyhow!("missing WS auth token"))?;

        let params = build_cancel_order_params(cmd, token);
        let identity = PendingRequest {
            operation: PendingOperation::Cancel,
            client_order_ids: vec![cmd.client_order_id],
            venue_order_ids: vec![cmd.venue_order_id],
            ts_sent_ns: 0,
            new_quantity: None,
            new_price: None,
            new_trigger_price: None,
        };
        self.order_request_state
            .cancel(params, identity, self.clock.get_time_ns().as_u64())?;
        Ok(())
    }

    fn spawn_message_handler(&mut self) -> anyhow::Result<()> {
        let stream = self.ws.stream().map_err(|e| anyhow::anyhow!("{e}"))?;
        let emitter = self.emitter.clone();
        let instruments = self.instruments.clone();
        let order_qty_cache = self.order_qty_cache.clone();
        let truncated_id_map = self.truncated_id_map.clone();
        let dispatch_state = self.ws_dispatch_state.clone();
        let order_request_state = self.order_request_state.clone();
        let account_id = self.core.account_id;
        let clock = self.clock;
        let cancellation_token = self.cancellation_token.clone();

        let handle = get_runtime().spawn(async move {
            tokio::pin!(stream);

            loop {
                tokio::select! {
                    () = cancellation_token.cancelled() => {
                        log::debug!("Spot execution message handler cancelled");
                        break;
                    }
                    msg = stream.next() => {
                        match msg {
                            Some(ws_msg) => {
                                Self::handle_ws_message(
                                    ws_msg,
                                    &emitter,
                                    &dispatch_state,
                                    &order_request_state,
                                    &instruments,
                                    &order_qty_cache,
                                    &truncated_id_map,
                                    account_id,
                                    clock,
                                );
                            }
                            None => {
                                log::debug!("Spot execution WebSocket stream ended");
                                break;
                            }
                        }
                    }
                }
            }
        });

        self.ws_stream_handle = Some(handle);

        let event_rx = self.order_event_rx.lock().expect(MUTEX_POISONED).take();

        if let Some(mut event_rx) = event_rx {
            let emitter = self.emitter.clone();
            let cancellation_token = self.cancellation_token.clone();

            get_runtime().spawn(async move {
                loop {
                    tokio::select! {
                        () = cancellation_token.cancelled() => {
                            log::debug!("Spot execution order-event forwarder cancelled");
                            break;
                        }
                        event = event_rx.recv() => {
                            match event {
                                Some(event) => emitter.send_order_event(event),
                                None => {
                                    log::debug!("Spot execution order-event channel closed");
                                    break;
                                }
                            }
                        }
                    }
                }
            });
        }

        Ok(())
    }

    fn modify_single_order(&self, cmd: &ModifyOrder) {
        let use_ws_trade = resolve_use_ws_trade(cmd.params.as_ref(), self.config.use_ws_trade);
        if use_ws_trade && self.ws.is_active() {
            match self.amend_via_ws(cmd) {
                Ok(()) => return,
                Err(e) => log::warn!("Kraken WS amend_order fallback to REST: {e}"),
            }
        }

        self.amend_via_rest(cmd);
    }

    fn amend_via_rest(&self, cmd: &ModifyOrder) {
        let client_order_id = cmd.client_order_id;
        let venue_order_id = cmd.venue_order_id;
        let strategy_id = cmd.strategy_id;
        let instrument_id = cmd.instrument_id;
        let quantity = cmd.quantity;
        let price = cmd.price;

        log::debug!(
            "Modifying order: venue_order_id={venue_order_id:?}, client_order_id={client_order_id}"
        );

        let http = self.http.clone();
        let emitter = self.emitter.clone();
        let clock = self.clock;

        self.spawn_task("modify_order", async move {
            if let Err(e) = http
                .modify_order(
                    instrument_id,
                    Some(client_order_id),
                    venue_order_id,
                    quantity,
                    price,
                    None,
                )
                .await
            {
                let ts_event = clock.get_time_ns();
                emitter.emit_order_modify_rejected_event(
                    strategy_id,
                    instrument_id,
                    client_order_id,
                    venue_order_id,
                    &format!("modify-order error: {e}"),
                    ts_event,
                );
                anyhow::bail!("Modify order failed: {e}");
            }
            Ok(())
        });
    }

    fn amend_via_ws(&self, cmd: &ModifyOrder) -> anyhow::Result<()> {
        let token = self
            .ws
            .auth_token_blocking()
            .ok_or_else(|| anyhow::anyhow!("missing WS auth token"))?;

        let params = build_amend_order_params(cmd, token);
        let identity = PendingRequest {
            operation: PendingOperation::Amend,
            client_order_ids: vec![cmd.client_order_id],
            venue_order_ids: vec![cmd.venue_order_id],
            ts_sent_ns: 0,
            new_quantity: cmd.quantity,
            new_price: cmd.price,
            new_trigger_price: cmd.trigger_price,
        };
        self.order_request_state
            .amend(params, identity, self.clock.get_time_ns().as_u64())?;
        Ok(())
    }

    /// Polls the cache until the account is registered or timeout is reached.
    async fn await_account_registered(&self, timeout_secs: f64) -> anyhow::Result<()> {
        let account_id = self.core.account_id;

        if self.core.cache().account(&account_id).is_some() {
            log::info!("Account {account_id} registered");
            return Ok(());
        }

        let start = Instant::now();
        let timeout = Duration::from_secs_f64(timeout_secs);
        let interval = Duration::from_millis(10);

        loop {
            tokio::time::sleep(interval).await;

            if self.core.cache().account(&account_id).is_some() {
                log::info!("Account {account_id} registered");
                return Ok(());
            }

            if start.elapsed() >= timeout {
                anyhow::bail!(
                    "Timeout waiting for account {account_id} to be registered after {timeout_secs}s"
                );
            }
        }
    }

    #[expect(clippy::too_many_arguments)]
    fn handle_ws_message(
        msg: KrakenSpotWsMessage,
        emitter: &ExecutionEventEmitter,
        dispatch_state: &Arc<WsDispatchState>,
        order_request_state: &Arc<OrderRequestState>,
        instruments: &Arc<AtomicMap<InstrumentId, InstrumentAny>>,
        order_qty_cache: &Arc<AtomicMap<String, f64>>,
        truncated_id_map: &Arc<AtomicMap<String, ClientOrderId>>,
        account_id: AccountId,
        clock: &'static AtomicTime,
    ) {
        match msg {
            KrakenSpotWsMessage::Execution(executions) => {
                let ts_init = clock.get_time_ns();

                for exec in &executions {
                    dispatch::spot::execution(
                        exec,
                        dispatch_state,
                        emitter,
                        instruments,
                        truncated_id_map,
                        order_qty_cache,
                        account_id,
                        ts_init,
                    );
                }
            }
            KrakenSpotWsMessage::OrderResponse(response) => {
                let ts_event = clock.get_time_ns().as_u64();
                order_request_state.handle_response(&response, ts_event);
            }
            KrakenSpotWsMessage::Reconnected => {
                log::info!("Spot execution WebSocket reconnected");
            }
            KrakenSpotWsMessage::Ticker(_)
            | KrakenSpotWsMessage::Trade(_)
            | KrakenSpotWsMessage::Book { .. }
            | KrakenSpotWsMessage::Ohlc(_)
            | KrakenSpotWsMessage::L3Snapshot(_)
            | KrakenSpotWsMessage::L3Update(_) => {}
        }
    }

    fn sweep_stale_margin_positions(
        &self,
        account_id: AccountId,
        reports: &mut Vec<PositionStatusReport>,
    ) {
        let reported: HashSet<InstrumentId> = reports
            .iter()
            .filter(|r| r.position_side != PositionSideSpecified::Flat)
            .map(|r| r.instrument_id)
            .collect();

        let ts_now = self.clock.get_time_ns();
        let cache = self.core.cache();
        let open_positions =
            cache.positions_open(Some(&*KRAKEN_VENUE), None, None, Some(&account_id), None);

        for pos in open_positions {
            let inst_id = pos.instrument_id;

            if product_type_from_symbol(inst_id.symbol.inner().as_str()) != KrakenProductType::Spot
            {
                continue;
            }

            if reported.contains(&inst_id) {
                continue;
            }

            let precision = cache.instrument(&inst_id).map_or(0, |i| i.size_precision());
            log::debug!("Emitting synthetic FLAT for closed margin position {inst_id}");
            reports.push(PositionStatusReport::new(
                account_id,
                inst_id,
                PositionSideSpecified::Flat,
                Quantity::zero(precision),
                ts_now,
                ts_now,
                None,
                None,
                None,
            ));
        }
    }

    fn batch_add_via_rest(
        &self,
        order_tuples: Vec<BatchOrderTuple>,
        order_meta: Vec<(StrategyId, InstrumentId, ClientOrderId)>,
    ) {
        let http = self.http.clone();
        let emitter = self.emitter.clone();
        let clock = self.clock;
        let dispatch_state = self.ws_dispatch_state.clone();
        let spot_account_type = self.config.spot_account_type;

        self.spawn_task("submit_order_list", async move {
            match http
                .submit_orders_batch(order_tuples, spot_account_type)
                .await
            {
                Ok(statuses) => {
                    for (i, status) in statuses.iter().enumerate() {
                        if status != "placed"
                            && let Some((strategy_id, instrument_id, client_order_id)) =
                                order_meta.get(i)
                        {
                            let ts_event = clock.get_time_ns();
                            let due_post_only = status.contains("POST_ONLY_REJECTED")
                                || status.contains(KRAKEN_SPOT_POST_ONLY_ERROR);
                            dispatch_state.cleanup_terminal(client_order_id);
                            emitter.emit_order_rejected_event(
                                *strategy_id,
                                *instrument_id,
                                *client_order_id,
                                &format!("submit_order_list batch item rejected: {status}"),
                                ts_event,
                                due_post_only,
                            );
                        }
                    }
                    Ok(())
                }
                Err(e) => {
                    let ts_event = clock.get_time_ns();
                    let error_msg = format!("submit_order_list batch error: {e}");

                    for (strategy_id, instrument_id, client_order_id) in &order_meta {
                        dispatch_state.cleanup_terminal(client_order_id);
                        emitter.emit_order_rejected_event(
                            *strategy_id,
                            *instrument_id,
                            *client_order_id,
                            &error_msg,
                            ts_event,
                            false,
                        );
                    }
                    Ok(())
                }
            }
        });
    }

    fn batch_add_via_ws(&self, orders: &[OrderAny], leverage: Option<u16>) -> anyhow::Result<()> {
        let token = self
            .ws
            .auth_token_blocking()
            .ok_or_else(|| anyhow::anyhow!("missing WS auth token"))?;

        let first = orders
            .first()
            .ok_or_else(|| anyhow::anyhow!("batch_add requires at least one order"))?;
        let symbol = first.instrument_id().symbol.inner().to_string();

        let mut batch_orders = Vec::with_capacity(orders.len());
        let mut client_order_ids = Vec::with_capacity(orders.len());
        for order in orders {
            batch_orders.push(build_batch_order(order, leverage)?);
            client_order_ids.push(order.client_order_id());
        }
        let venue_order_ids = vec![None; orders.len()];

        let params = KrakenWsBatchAddParams {
            symbol,
            orders: batch_orders,
            token,
        };
        let identity = PendingRequest {
            operation: PendingOperation::BatchAdd,
            client_order_ids,
            venue_order_ids,
            ts_sent_ns: 0,
            new_quantity: None,
            new_price: None,
            new_trigger_price: None,
        };
        self.order_request_state
            .batch_add(params, identity, self.clock.get_time_ns().as_u64())?;
        Ok(())
    }
}

type BatchOrderTuple = (
    InstrumentId,
    ClientOrderId,
    OrderSide,
    OrderType,
    Quantity,
    TimeInForce,
    Option<UnixNanos>,
    Option<Price>,
    Option<Price>,
    Option<TriggerType>,
    Option<Decimal>,
    Option<Decimal>,
    bool,
    bool,
    bool,
    Option<Quantity>,
    Option<u16>,
);

fn build_batch_order(
    order: &OrderAny,
    leverage: Option<u16>,
) -> anyhow::Result<KrakenWsBatchAddOrder> {
    let order_type = order.order_type();
    let side = match order.order_side() {
        OrderSide::Buy => KrakenOrderSide::Buy,
        OrderSide::Sell => KrakenOrderSide::Sell,
        side => anyhow::bail!("Invalid order side: {side:?}"),
    };

    if matches!(
        order_type,
        OrderType::TrailingStopMarket | OrderType::TrailingStopLimit
    ) {
        anyhow::bail!(
            "Trailing stop orders are not yet supported on the Kraken WS batch path; use REST",
        );
    }

    if order.display_qty().is_some() {
        anyhow::bail!(
            "Iceberg (display_qty) orders are not supported on the Kraken WS batch path; use REST",
        );
    }

    let kraken_order_type = match order_type {
        OrderType::Market => KrakenOrderType::Market,
        OrderType::Limit => KrakenOrderType::Limit,
        OrderType::StopMarket => KrakenOrderType::StopLoss,
        OrderType::StopLimit => KrakenOrderType::StopLossLimit,
        OrderType::MarketIfTouched => KrakenOrderType::TakeProfit,
        OrderType::LimitIfTouched => KrakenOrderType::TakeProfitLimit,
        ty => anyhow::bail!("Unsupported order type for Kraken WS batch: {ty:?}"),
    };

    let is_limit_order = matches!(
        order_type,
        OrderType::Limit | OrderType::StopLimit | OrderType::LimitIfTouched
    );

    if is_limit_order && order.price().is_none() {
        anyhow::bail!("limit_price is required for batch order type {order_type:?}");
    }

    let ws_tif =
        compute_ws_time_in_force(is_limit_order, order.time_in_force(), order.expire_time())?;
    let expire_time = match (ws_tif, order.expire_time()) {
        (Some(KrakenTimeInForce::GoodTilDate), Some(ts)) => Some(format_expire_time(ts)),
        _ => None,
    };

    let is_conditional = matches!(
        order_type,
        OrderType::StopMarket
            | OrderType::StopLimit
            | OrderType::MarketIfTouched
            | OrderType::LimitIfTouched
    );

    let trigger = if is_conditional {
        let trigger_ref = match order.trigger_type() {
            Some(TriggerType::IndexPrice) => KrakenSpotTrigger::Index,
            Some(TriggerType::LastPrice | TriggerType::Default) | None => KrakenSpotTrigger::Last,
            Some(other) => anyhow::bail!(
                "Unsupported trigger type for Kraken Spot WS batch: {other:?} (only LastPrice and IndexPrice supported)",
            ),
        };
        order.trigger_price().map(|tp| KrakenWsTriggerParams {
            reference: trigger_ref,
            price: tp.as_f64(),
            price_type: None,
        })
    } else {
        None
    };

    if is_conditional && trigger.is_none() {
        anyhow::bail!(
            "Conditional order type {order_type:?} requires trigger_price for Kraken WS batch",
        );
    }

    Ok(KrakenWsBatchAddOrder {
        order_type: kraken_order_type,
        side,
        order_qty: order.quantity().as_f64(),
        limit_price: order.price().map(|p| p.as_f64()),
        cl_ord_id: Some(truncate_cl_ord_id(&order.client_order_id())),
        time_in_force: ws_tif,
        expire_time,
        post_only: order.is_post_only().then_some(true),
        reduce_only: order.is_reduce_only().then_some(true),
        leverage,
        trigger,
    })
}

#[async_trait(?Send)]
impl ExecutionClient for KrakenSpotExecutionClient {
    fn is_connected(&self) -> bool {
        self.core.is_connected()
    }

    fn client_id(&self) -> ClientId {
        self.core.client_id
    }

    fn account_id(&self) -> AccountId {
        self.core.account_id
    }

    fn venue(&self) -> Venue {
        *KRAKEN_VENUE
    }

    fn oms_type(&self) -> OmsType {
        self.core.oms_type
    }

    fn get_account(&self) -> Option<AccountAny> {
        self.core.cache().account_owned(&self.core.account_id)
    }

    fn generate_account_state(
        &self,
        balances: Vec<AccountBalance>,
        margins: Vec<MarginBalance>,
        reported: bool,
        ts_event: UnixNanos,
    ) -> anyhow::Result<()> {
        self.emitter
            .emit_account_state(balances, margins, reported, ts_event);
        Ok(())
    }

    fn start(&mut self) -> anyhow::Result<()> {
        if self.core.is_started() {
            return Ok(());
        }

        self.emitter.set_sender(get_exec_event_sender());
        self.core.set_started();

        log::info!(
            "Started: client_id={}, account_id={}, product_type=Spot, environment={:?}",
            self.core.client_id,
            self.core.account_id,
            self.config.environment
        );
        Ok(())
    }

    fn stop(&mut self) -> anyhow::Result<()> {
        if self.core.is_stopped() {
            return Ok(());
        }

        self.cancellation_token.cancel();
        self.core.set_stopped();
        self.core.set_disconnected();
        log::info!("Stopped: client_id={}", self.core.client_id);
        Ok(())
    }

    async fn connect(&mut self) -> anyhow::Result<()> {
        if self.core.is_connected() {
            return Ok(());
        }

        if !self.core.instruments_initialized() {
            let instruments = self
                .http
                .request_instruments(None)
                .await
                .context("Failed to load Kraken spot instruments")?;
            log::debug!("Loaded {} Spot instruments", instruments.len());
            self.http.cache_instruments(&instruments);
            self.core.set_instruments_initialized();
        }

        self.ws
            .connect()
            .await
            .context("Failed to connect spot WebSocket")?;
        self.ws
            .wait_until_active(10.0)
            .await
            .context("Spot WebSocket failed to become active")?;

        self.ws
            .authenticate()
            .await
            .context("Failed to authenticate spot WebSocket")?;

        // Request initial account state and await registration before spawning
        // the message handler. Report events from execution snapshots conflict
        // with ExecEngine borrows during startup, so account registration must
        // complete first.
        let account_state = self
            .http
            .request_account_state(
                self.core.account_id,
                self.config.spot_account_type,
                self.config.margin_balance_asset.as_deref(),
            )
            .await
            .context("Failed to request Kraken account state")?;

        if !account_state.balances.is_empty() {
            log::debug!(
                "Received account state with {} balance(s)",
                account_state.balances.len()
            );
        }

        self.emitter.send_account_state(account_state);
        self.await_account_registered(30.0).await?;

        self.spawn_message_handler()?;

        self.instruments.rcu(|m| {
            for instrument in self.http.instruments_cache.load().values() {
                m.insert(instrument.id(), instrument.clone());
            }
        });

        self.ws
            .subscribe_executions(false, false)
            .await
            .context("Failed to subscribe to executions")?;

        log::debug!("Spot WebSocket authenticated and subscribed to executions");

        self.core.set_connected();
        log::info!("Connected: client_id={}", self.core.client_id);
        Ok(())
    }

    async fn disconnect(&mut self) -> anyhow::Result<()> {
        if self.core.is_disconnected() {
            return Ok(());
        }

        self.cancellation_token.cancel();

        if let Some(handle) = self.ws_stream_handle.take() {
            handle.abort();
        }

        let _ = self.ws.close().await;

        self.cancellation_token = CancellationToken::new();
        self.core.set_disconnected();
        log::info!("Disconnected: client_id={}", self.core.client_id);
        Ok(())
    }

    async fn generate_order_status_report(
        &self,
        cmd: &GenerateOrderStatusReport,
    ) -> anyhow::Result<Option<OrderStatusReport>> {
        log::debug!(
            "Generating order status report: venue_order_id={:?}, client_order_id={:?}",
            cmd.venue_order_id,
            cmd.client_order_id
        );

        let account_id = self.core.account_id;
        let reports = self
            .http
            .request_order_status_reports(account_id, None, None, None, false)
            .await?;

        // Match by venue_order_id or client_order_id (comparing truncated form
        // since Kraken stores the truncated cl_ord_id for long IDs)
        Ok(reports.into_iter().find(|r| {
            cmd.venue_order_id
                .is_some_and(|id| r.venue_order_id.as_str() == id.as_str())
                || cmd.client_order_id.is_some_and(|id| {
                    r.client_order_id
                        .as_ref()
                        .is_some_and(|r_id| r_id.as_str() == truncate_cl_ord_id(&id))
                })
        }))
    }

    async fn generate_order_status_reports(
        &self,
        cmd: &GenerateOrderStatusReports,
    ) -> anyhow::Result<Vec<OrderStatusReport>> {
        log::debug!(
            "Generating order status reports: instrument_id={:?}, open_only={}",
            cmd.instrument_id,
            cmd.open_only
        );

        let account_id = self.core.account_id;
        let start = cmd.start.map(DateTime::<Utc>::from);
        let end = cmd.end.map(DateTime::<Utc>::from);
        self.http
            .request_order_status_reports(account_id, cmd.instrument_id, start, end, cmd.open_only)
            .await
    }

    async fn generate_fill_reports(
        &self,
        cmd: GenerateFillReports,
    ) -> anyhow::Result<Vec<FillReport>> {
        log::debug!(
            "Generating fill reports: instrument_id={:?}",
            cmd.instrument_id
        );

        let account_id = self.core.account_id;
        let start = cmd.start.map(DateTime::<Utc>::from);
        let end = cmd.end.map(DateTime::<Utc>::from);
        self.http
            .request_fill_reports(account_id, cmd.instrument_id, start, end)
            .await
    }

    async fn generate_position_status_reports(
        &self,
        cmd: &GeneratePositionStatusReports,
    ) -> anyhow::Result<Vec<PositionStatusReport>> {
        log::debug!(
            "Generating position status reports: instrument_id={:?}",
            cmd.instrument_id
        );

        let account_id = self.core.account_id;
        let mut reports = self
            .http
            .request_position_status_reports(
                account_id,
                cmd.instrument_id,
                self.config.spot_account_type,
                self.config.use_spot_position_reports,
                Ustr::from(self.config.spot_positions_quote_currency.as_str()),
            )
            .await?;

        if cmd.instrument_id.is_none() && self.config.spot_account_type == AccountType::Margin {
            self.sweep_stale_margin_positions(account_id, &mut reports);
        }

        Ok(reports)
    }

    async fn generate_mass_status(
        &self,
        lookback_mins: Option<u64>,
    ) -> anyhow::Result<Option<ExecutionMassStatus>> {
        log::debug!("Generating mass status: lookback_mins={lookback_mins:?}");

        let start = lookback_mins.map(|mins| Utc::now() - Duration::from_secs(mins * 60));

        let account_id = self.core.account_id;
        let order_reports = self
            .http
            .request_order_status_reports(account_id, None, start, None, true)
            .await?;
        let fill_reports = self
            .http
            .request_fill_reports(account_id, None, start, None)
            .await?;
        let mut position_reports = self
            .http
            .request_position_status_reports(
                account_id,
                None,
                self.config.spot_account_type,
                self.config.use_spot_position_reports,
                Ustr::from(self.config.spot_positions_quote_currency.as_str()),
            )
            .await?;

        if self.config.spot_account_type == AccountType::Margin {
            self.sweep_stale_margin_positions(account_id, &mut position_reports);
        }

        let mut mass_status = ExecutionMassStatus::new(
            self.core.client_id,
            self.core.account_id,
            *KRAKEN_VENUE,
            self.clock.get_time_ns(),
            None,
        );
        mass_status.add_order_reports(order_reports);
        mass_status.add_fill_reports(fill_reports);
        mass_status.add_position_reports(position_reports);

        Ok(Some(mass_status))
    }

    fn query_account(&self, cmd: QueryAccount) -> anyhow::Result<()> {
        log::debug!("Querying account: {cmd:?}");

        let account_id = self.core.account_id;
        let http = self.http.clone();
        let emitter = self.emitter.clone();

        let spot_account_type = self.config.spot_account_type;
        let margin_balance_asset = self.config.margin_balance_asset.clone();
        self.spawn_task("query_account", async move {
            let account_state = http
                .request_account_state(
                    account_id,
                    spot_account_type,
                    margin_balance_asset.as_deref(),
                )
                .await?;
            emitter.emit_account_state(
                account_state.balances.clone(),
                account_state.margins.clone(),
                account_state.is_reported,
                account_state.ts_event,
            );
            Ok(())
        });

        Ok(())
    }

    fn query_order(&self, cmd: QueryOrder) -> anyhow::Result<()> {
        log::debug!("Querying order: {cmd:?}");

        let venue_order_id = cmd
            .venue_order_id
            .context("venue_order_id required for query_order")?;
        let account_id = self.core.account_id;
        let http = self.http.clone();
        let emitter = self.emitter.clone();

        self.spawn_task("query_order", async move {
            let reports = http
                .request_order_status_reports(account_id, None, None, None, true)
                .await
                .context("Failed to query order")?;

            if let Some(report) = reports
                .into_iter()
                .find(|r| r.venue_order_id == venue_order_id)
            {
                emitter.send_order_status_report(report);
            }
            Ok(())
        });

        Ok(())
    }

    fn submit_order(&self, cmd: SubmitOrder) -> anyhow::Result<()> {
        let order = self.core.cache().try_order_owned(&cmd.client_order_id)?;
        let leverage = match resolve_leverage(cmd.params.as_ref(), self.config.default_leverage) {
            Ok(lev) => lev,
            Err(reason) => {
                self.emitter.emit_order_denied(&order, &reason);
                return Ok(());
            }
        };
        self.submit_single_order(&cmd, &order, "submit_order", leverage);
        Ok(())
    }

    fn submit_order_list(&self, cmd: SubmitOrderList) -> anyhow::Result<()> {
        let orders = self.core.get_orders_for_list(&cmd.order_list)?;

        log::debug!(
            "Submitting order list: order_list_id={}, count={}",
            cmd.order_list.id,
            orders.len()
        );

        let leverage = match resolve_leverage(cmd.params.as_ref(), self.config.default_leverage) {
            Ok(lev) => lev,
            Err(reason) => {
                for order in &orders {
                    self.emitter.emit_order_denied(order, &reason);
                }
                return Ok(());
            }
        };

        let mut order_tuples = Vec::with_capacity(orders.len());
        let mut order_meta = Vec::with_capacity(orders.len());
        let mut prepared_orders = Vec::with_capacity(orders.len());

        for order in &orders {
            if order.is_closed() {
                log::warn!(
                    "Cannot submit closed order: client_order_id={}",
                    order.client_order_id()
                );
                continue;
            }

            if order.time_in_force() == TimeInForce::Fok && order.order_type() != OrderType::Limit {
                self.emitter.emit_order_denied(
                    order,
                    "FOK time in force only supported for LIMIT orders on Kraken Spot",
                );
                continue;
            }

            if matches!(
                order.order_type(),
                OrderType::TrailingStopMarket | OrderType::TrailingStopLimit
            ) && let Some(offset_type) = order.trailing_offset_type()
                && offset_type != TrailingOffsetType::Price
            {
                self.emitter.emit_order_denied(
                    order,
                    &format!(
                        "Kraken Spot only supports Price trailing offset type: received {offset_type:?}"
                    ),
                );
                continue;
            }

            if order.is_reduce_only() && self.config.spot_account_type == AccountType::Cash {
                self.emitter
                    .emit_order_denied(order, "reduce_only requires spot_account_type=Margin");
                continue;
            }

            let client_order_id = order.client_order_id();
            let kraken_cl_ord_id = truncate_cl_ord_id(&client_order_id);

            self.register_order_identity(order);
            self.emitter.emit_order_submitted(order);

            if !order.is_quote_quantity() {
                self.order_qty_cache
                    .insert(kraken_cl_ord_id.clone(), order.quantity().as_f64());
            }

            if kraken_cl_ord_id != client_order_id.as_str() {
                self.truncated_id_map
                    .insert(kraken_cl_ord_id, client_order_id);
            }
            order_tuples.push((
                order.instrument_id(),
                client_order_id,
                order.order_side(),
                order.order_type(),
                order.quantity(),
                order.time_in_force(),
                order.expire_time(),
                order.price(),
                order.trigger_price(),
                order.trigger_type(),
                order.trailing_offset(),
                order.limit_offset(),
                order.is_reduce_only(),
                order.is_post_only(),
                order.is_quote_quantity(),
                order.display_qty(),
                leverage,
            ));

            order_meta.push((order.strategy_id(), order.instrument_id(), client_order_id));
            prepared_orders.push(order.clone());
        }

        if order_tuples.is_empty() {
            return Ok(());
        }

        let use_ws_trade = resolve_use_ws_trade(cmd.params.as_ref(), self.config.use_ws_trade);
        if use_ws_trade && self.ws.is_active() {
            let any_quote_qty = prepared_orders.iter().any(|o| o.is_quote_quantity());
            let symbols_match = prepared_orders
                .windows(2)
                .all(|w| w[0].instrument_id() == w[1].instrument_id());

            if any_quote_qty {
                log::warn!(
                    "Kraken WS batch_add does not support quote-quantity orders, falling back to REST for order_list_id={}",
                    cmd.order_list.id,
                );
            } else if symbols_match {
                match self.batch_add_via_ws(&prepared_orders, leverage) {
                    Ok(()) => return Ok(()),
                    Err(e) => log::warn!("Kraken WS batch_add fallback to REST: {e}"),
                }
            } else {
                log::warn!(
                    "Kraken WS batch_add requires single shared symbol, falling back to REST for order_list_id={}",
                    cmd.order_list.id,
                );
            }
        }

        self.batch_add_via_rest(order_tuples, order_meta);

        Ok(())
    }

    fn modify_order(&self, cmd: ModifyOrder) -> anyhow::Result<()> {
        self.modify_single_order(&cmd);
        Ok(())
    }

    fn cancel_order(&self, cmd: CancelOrder) -> anyhow::Result<()> {
        self.cancel_single_order(&cmd);
        Ok(())
    }

    fn cancel_all_orders(&self, cmd: CancelAllOrders) -> anyhow::Result<()> {
        let instrument_id = cmd.instrument_id;

        if cmd.order_side == OrderSide::NoOrderSide {
            log::debug!("Canceling all orders: instrument_id={instrument_id} (bulk)");

            let http = self.http.clone();

            self.spawn_task("cancel_all_orders", async move {
                if let Err(e) = http.inner.cancel_all_orders().await {
                    match classify_cancel_http_failure(e) {
                        CancelCommandFailure::LocalValidation(reason) => {
                            log::warn!("Cancel-all failed local validation: {reason}");
                        }
                        CancelCommandFailure::Ambiguous(reason)
                        | CancelCommandFailure::VenueReject(reason) => {
                            log::warn!(
                                "Cancel-all ambiguous failure, awaiting reconciliation: {reason}"
                            );
                        }
                    }
                }
                Ok(())
            });

            return Ok(());
        }

        log::debug!(
            "Canceling all orders: instrument_id={instrument_id}, side={:?}",
            cmd.order_side
        );

        let orders_to_cancel: Vec<_> = {
            let cache = self.core.cache();
            let open_orders = cache.orders_open(None, Some(&instrument_id), None, None, None);

            open_orders
                .into_iter()
                .filter(|order| order.order_side() == cmd.order_side)
                .filter_map(|order| {
                    Some((
                        order.venue_order_id()?,
                        order.client_order_id(),
                        order.instrument_id(),
                        order.strategy_id(),
                    ))
                })
                .collect()
        };

        let account_id = self.core.account_id;

        for (venue_order_id, client_order_id, order_instrument_id, strategy_id) in orders_to_cancel
        {
            let http = self.http.clone();
            let emitter = self.emitter.clone();
            let clock = self.clock;

            self.spawn_task("cancel_order_by_side", async move {
                if let Err(failure) = cancel_order_for_spot(
                    &http,
                    account_id,
                    order_instrument_id,
                    Some(client_order_id),
                    Some(venue_order_id),
                )
                .await
                {
                    handle_cancel_failure(
                        &emitter,
                        clock,
                        strategy_id,
                        order_instrument_id,
                        client_order_id,
                        Some(venue_order_id),
                        failure,
                    );
                }
                Ok(())
            });
        }

        Ok(())
    }

    fn batch_cancel_orders(&self, cmd: BatchCancelOrders) -> anyhow::Result<()> {
        log::debug!(
            "Batch canceling orders: instrument_id={}, count={}",
            cmd.instrument_id,
            cmd.cancels.len()
        );

        let use_ws_trade = resolve_use_ws_trade(cmd.params.as_ref(), self.config.use_ws_trade);
        if use_ws_trade && self.ws.is_active() {
            for cancel in &cmd.cancels {
                self.cancel_single_order(cancel);
            }

            return Ok(());
        }

        let http = self.http.clone();
        let cancels = cmd.cancels;

        self.spawn_task("batch_cancel_orders", async move {
            batch_cancel_orders_for_spot(&http, &cancels).await;
            Ok(())
        });

        Ok(())
    }
}

async fn cancel_order_for_spot(
    http: &KrakenSpotHttpClient,
    _account_id: AccountId,
    instrument_id: InstrumentId,
    client_order_id: Option<ClientOrderId>,
    venue_order_id: Option<VenueOrderId>,
) -> Result<(), CancelCommandFailure> {
    http.get_cached_instrument(&instrument_id.symbol.inner())
        .ok_or_else(|| {
            CancelCommandFailure::local(InstrumentLookupError::not_found(instrument_id).to_string())
        })?;

    let txid = venue_order_id.as_ref().map(ToString::to_string);
    let cl_ord_id = client_order_id.as_ref().map(truncate_cl_ord_id);

    if txid.is_none() && cl_ord_id.is_none() {
        return Err(CancelCommandFailure::local(
            "Either client_order_id or venue_order_id must be provided",
        ));
    }

    let mut builder = KrakenSpotCancelOrderParamsBuilder::default();

    if let Some(ref id) = txid {
        builder.txid(id.clone());
    } else if let Some(ref id) = cl_ord_id {
        builder.cl_ord_id(id.clone());
    }

    let params = builder
        .build()
        .map_err(|e| CancelCommandFailure::local(format!("Failed to build cancel params: {e}")))?;

    http.inner
        .cancel_order(&params)
        .await
        .map_err(classify_spot_single_cancel_http_failure)?;

    Ok(())
}

async fn batch_cancel_orders_for_spot(http: &KrakenSpotHttpClient, cancels: &[CancelOrder]) {
    let mut orders = Vec::new();

    for cancel in cancels {
        match batch_cancel_item_for_spot(http, cancel) {
            Ok(order) => orders.push(order),
            Err(CancelCommandFailure::LocalValidation(reason)) => {
                log::warn!(
                    "Batch cancel command failed local validation for {}: {reason}",
                    cancel.client_order_id
                );
            }
            Err(
                CancelCommandFailure::Ambiguous(reason) | CancelCommandFailure::VenueReject(reason),
            ) => {
                log::warn!(
                    "Batch cancel command ambiguous failure for {}, awaiting reconciliation: {reason}",
                    cancel.client_order_id
                );
            }
        }
    }

    for chunk in orders.chunks(50) {
        let params = KrakenSpotCancelOrderBatchParams {
            orders: chunk.to_vec(),
        };

        match http.inner.cancel_order_batch(&params).await {
            Ok(response) => {
                if response.count < chunk.len() as i32 {
                    log::warn!(
                        "Batch cancel accepted {} of {} request(s) without per-order results; awaiting reconciliation",
                        response.count,
                        chunk.len()
                    );
                }
            }
            Err(e) => match classify_cancel_http_failure(e) {
                CancelCommandFailure::LocalValidation(reason) => {
                    log::warn!("Batch cancel failed local validation: {reason}");
                }
                CancelCommandFailure::Ambiguous(reason)
                | CancelCommandFailure::VenueReject(reason) => {
                    log::warn!(
                        "Batch cancel failed without per-order results, awaiting reconciliation: {reason}"
                    );
                }
            },
        }
    }
}

fn batch_cancel_item_for_spot(
    http: &KrakenSpotHttpClient,
    cancel: &CancelOrder,
) -> Result<String, CancelCommandFailure> {
    http.get_cached_instrument(&cancel.instrument_id.symbol.inner())
        .ok_or_else(|| {
            CancelCommandFailure::local(
                InstrumentLookupError::not_found(cancel.instrument_id).to_string(),
            )
        })?;

    if let Some(venue_order_id) = cancel.venue_order_id {
        Ok(venue_order_id.to_string())
    } else {
        Ok(truncate_cl_ord_id(&cancel.client_order_id))
    }
}

fn handle_cancel_failure(
    emitter: &ExecutionEventEmitter,
    clock: &'static AtomicTime,
    strategy_id: StrategyId,
    instrument_id: InstrumentId,
    client_order_id: ClientOrderId,
    venue_order_id: Option<VenueOrderId>,
    failure: CancelCommandFailure,
) {
    match failure {
        CancelCommandFailure::VenueReject(reason) => {
            emitter.emit_order_cancel_rejected_event(
                strategy_id,
                instrument_id,
                client_order_id,
                venue_order_id,
                &reason,
                clock.get_time_ns(),
            );
        }
        CancelCommandFailure::LocalValidation(reason) => {
            log::warn!("Cancel command failed local validation for {client_order_id}: {reason}");
        }
        CancelCommandFailure::Ambiguous(reason) => {
            log::warn!(
                "Ambiguous cancel failure for {client_order_id}, awaiting reconciliation: {reason}"
            );
        }
    }
}

fn resolve_leverage(params: Option<&Params>, default: Option<u16>) -> Result<Option<u16>, String> {
    let Some(p) = params else {
        return Ok(default);
    };
    let Some(raw) = p.get("leverage") else {
        return Ok(default);
    };
    let n = raw.as_u64().ok_or_else(|| {
        format!("Invalid leverage param: expected unsigned integer, received {raw}")
    })?;
    let lev =
        u16::try_from(n).map_err(|_| format!("leverage {n} exceeds maximum ({})", u16::MAX))?;
    Ok(Some(lev))
}

/// Resolves the per-call `params["use_ws_trade"]` override against the
/// configured default. Non-boolean values warn and fall back to the default.
fn resolve_use_ws_trade(params: Option<&Params>, default: bool) -> bool {
    let Some(p) = params else {
        return default;
    };
    let Some(raw) = p.get("use_ws_trade") else {
        return default;
    };

    match raw.as_bool() {
        Some(b) => b,
        None => {
            log::warn!(
                "Invalid use_ws_trade param: expected boolean, received {raw}; using default {default}",
            );
            default
        }
    }
}

#[cfg(test)]
mod tests {
    use std::{cell::RefCell, rc::Rc};

    use nautilus_common::{
        cache::{Cache, InstrumentLookupError},
        clock::TestClock,
        factories::ExecutionClientFactory,
        messages::execution::CancelOrder,
    };
    use nautilus_core::{Params, UUID4, UnixNanos};
    use nautilus_model::identifiers::{
        AccountId, ClientOrderId, InstrumentId, StrategyId, TraderId, VenueOrderId,
    };
    use rstest::rstest;
    use serde_json::json;

    use super::{
        batch_cancel_item_for_spot, cancel_order_for_spot, resolve_leverage, resolve_use_ws_trade,
    };
    use crate::{
        common::enums::KrakenProductType, config::KrakenExecClientConfig,
        execution::CancelCommandFailure, factories::KrakenExecutionClientFactory,
        http::KrakenSpotHttpClient,
    };

    const TEST_INSTRUMENT_ID: &str = "BTC/USDT.KRAKEN";

    fn params_with(key: &str, val: serde_json::Value) -> Params {
        let mut map = indexmap::IndexMap::new();
        map.insert(key.to_owned(), val);
        Params::from_index_map(map)
    }

    #[tokio::test]
    async fn test_cancel_order_for_spot_missing_cached_instrument_returns_canonical_error() {
        let http = KrakenSpotHttpClient::default();
        let instrument_id = InstrumentId::from(TEST_INSTRUMENT_ID);
        let client_order_id = ClientOrderId::from("C-001");
        let venue_order_id = VenueOrderId::from("V-001");

        let result = cancel_order_for_spot(
            &http,
            AccountId::from("KRAKEN-001"),
            instrument_id,
            Some(client_order_id),
            Some(venue_order_id),
        )
        .await;

        match result {
            Err(CancelCommandFailure::LocalValidation(reason)) => {
                assert_eq!(
                    reason,
                    InstrumentLookupError::not_found(instrument_id).to_string()
                );
            }
            _ => panic!("Expected local validation failure"),
        }
    }

    #[rstest]
    fn test_batch_cancel_item_for_spot_missing_cached_instrument_returns_canonical_error() {
        let http = KrakenSpotHttpClient::default();
        let instrument_id = InstrumentId::from(TEST_INSTRUMENT_ID);
        let cancel = CancelOrder::new(
            TraderId::from("TESTER-001"),
            None,
            StrategyId::from("S-001"),
            instrument_id,
            ClientOrderId::from("C-001"),
            Some(VenueOrderId::from("V-001")),
            UUID4::new(),
            UnixNanos::default(),
            None,
            None,
        );

        let result = batch_cancel_item_for_spot(&http, &cancel);

        match result {
            Err(CancelCommandFailure::LocalValidation(reason)) => {
                assert_eq!(
                    reason,
                    InstrumentLookupError::not_found(instrument_id).to_string()
                );
            }
            _ => panic!("Expected local validation failure"),
        }
    }

    #[rstest]
    fn test_resolve_leverage_absent_uses_default() {
        let p = params_with("other", json!(1));
        assert_eq!(resolve_leverage(Some(&p), Some(3)).unwrap(), Some(3));
        assert_eq!(resolve_leverage(None, Some(5)).unwrap(), Some(5));
        assert_eq!(resolve_leverage(None, None).unwrap(), None);
    }

    #[rstest]
    fn test_resolve_leverage_valid_integer() {
        let p = params_with("leverage", json!(5u64));
        assert_eq!(resolve_leverage(Some(&p), Some(3)).unwrap(), Some(5));
    }

    #[rstest]
    fn test_resolve_leverage_string_value_errors() {
        let p = params_with("leverage", json!("5"));
        let err = resolve_leverage(Some(&p), Some(3)).unwrap_err();
        assert!(err.contains("Invalid leverage param"), "unexpected: {err}");
    }

    #[rstest]
    fn test_resolve_leverage_overflow_errors() {
        let p = params_with("leverage", json!(65539u64));
        let err = resolve_leverage(Some(&p), None).unwrap_err();
        assert!(err.contains("exceeds maximum"), "unexpected: {err}");
    }

    #[rstest]
    fn test_resolve_use_ws_trade_absent_uses_default() {
        let p = params_with("other", json!(1));
        assert!(resolve_use_ws_trade(Some(&p), true));
        assert!(!resolve_use_ws_trade(Some(&p), false));
        assert!(resolve_use_ws_trade(None, true));
        assert!(!resolve_use_ws_trade(None, false));
    }

    #[rstest]
    fn test_resolve_use_ws_trade_overrides_default() {
        let p_false = params_with("use_ws_trade", json!(false));
        let p_true = params_with("use_ws_trade", json!(true));
        assert!(!resolve_use_ws_trade(Some(&p_false), true));
        assert!(resolve_use_ws_trade(Some(&p_true), false));
    }

    #[rstest]
    fn test_resolve_use_ws_trade_non_boolean_falls_back_to_default() {
        let p = params_with("use_ws_trade", json!("true"));
        assert!(resolve_use_ws_trade(Some(&p), true));
        assert!(!resolve_use_ws_trade(Some(&p), false));
    }

    #[rstest]
    fn test_execution_client_constructs_with_ws_trade_enabled() {
        let factory = KrakenExecutionClientFactory::new();
        let config = KrakenExecClientConfig {
            product_type: KrakenProductType::Spot,
            use_ws_trade: true,
            ws_request_timeout_secs: 7,
            ..Default::default()
        };
        let cache = Rc::new(RefCell::new(Cache::default()));
        let _clock = Rc::new(RefCell::new(TestClock::new()));

        let result = factory.create("KRAKEN-WS", &config, cache.into());
        assert!(result.is_ok(), "construction failed: {:?}", result.err());
    }
}